[Mailer] File DNS transport #50962
Closed
[Mailer] File DNS transport #50962
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
OskarStark
requested changes
Jul 13, 2023
| use Psr\Log\LoggerInterface; | ||
| use Symfony\Component\Mailer\SentMessage; | ||
|
|
||
| use function _PHPStan_690619d82\RingCentral\Psr7\str; |
There was a problem hiding this comment.
Yes, leaked somehow. Fixed.
| */ | ||
| final class FileTransport extends AbstractTransport | ||
| { | ||
| public function __construct(EventDispatcherInterface $dispatcher = NULL, LoggerInterface $logger = NULL, protected Dsn $dsn) |
There was a problem hiding this comment.
Drupal coding standards :) Fixed.
| use Symfony\Component\Mailer\Exception\UnsupportedSchemeException; | ||
|
|
||
| /** | ||
| * @author ... |
| /** | ||
| * Sends the message to a file. | ||
| * | ||
| * @author Fabien Potencier <fabien@symfony.com> |
| use function _PHPStan_690619d82\RingCentral\Psr7\str; | ||
|
|
||
| /** | ||
| * Sends the message to a file. |
There was a problem hiding this comment.
Suggested change
| * Sends the message to a file. | |
| * Writes the message to a file. |
|
Added tests but I don't understand the failures. Seems not to be related |
|
@OskarStark I cannot change the status to "needs review". Also I cannot re-trigger the tests. It seems to me that those were random failures, anyway not related to this change |
|
Sorry, but I still think that this should not be provided by Symfony core (for the reasons I've listed in the linked ticket). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Provides a file DSN to be configured as
file://path/to/relative/file.txtorfile:///path/to/abolute/file.txt