Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update reviews guide to remove lgtm label #20257

Merged
merged 1 commit into from Aug 12, 2020

Conversation

crisbeto
Copy link
Member

@crisbeto crisbeto commented Aug 10, 2020

The reviews guide was referring to the lgtm label which was removed recently.

The reviews guide was referring to the `lgtm` label which was removed recently.
@crisbeto crisbeto added merge safe This PR does not affect library code used inside Google and can be merged without a Google presubmit P4 Low-priority issue that needs to be resolved target: patch This PR is targeted for the next patch release labels Aug 10, 2020
@crisbeto crisbeto requested a review from a team as a code owner Aug 10, 2020
@googlebot googlebot added the cla: yes PR author has agreed to Google's Contributor License Agreement label Aug 10, 2020
Copy link
Member

@josephperrott josephperrott left a comment

LGTM

@josephperrott josephperrott added the action: merge This PR is ready to run through Google's internal presubmit label Aug 10, 2020
@andrewseguin andrewseguin merged commit 9425ae5 into angular:master Aug 12, 2020
15 checks passed
andrewseguin pushed a commit that referenced this pull request Aug 12, 2020
The reviews guide was referring to the `lgtm` label which was removed recently.

(cherry picked from commit 9425ae5)
@angular-automatic-lock-bot
Copy link

angular-automatic-lock-bot bot commented Sep 12, 2020

This issue has been automatically locked due to inactivity.
Please file a new issue if you are encountering a similar or related problem.

Read more about our automatic conversation locking policy.

This action has been performed automatically by a bot.

@angular-automatic-lock-bot angular-automatic-lock-bot bot locked and limited conversation to collaborators Sep 12, 2020
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
action: merge This PR is ready to run through Google's internal presubmit cla: yes PR author has agreed to Google's Contributor License Agreement merge safe This PR does not affect library code used inside Google and can be merged without a Google presubmit P4 Low-priority issue that needs to be resolved target: patch This PR is targeted for the next patch release
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

6 participants