Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FrameworkBundle] Add --exclude option to the cache:pool:clear command #51058

Open
wants to merge 1 commit into
base: 6.4
Choose a base branch
from
Open

[FrameworkBundle] Add --exclude option to the cache:pool:clear command #51058

wants to merge 1 commit into from

Conversation

MatTheCat
Copy link
Contributor

@MatTheCat MatTheCat commented Jul 21, 2023 •
edited

Q A
Branch? 6.4
Bug fix? no
New feature? yes
Deprecations? no
Tickets Fix #51023
License MIT
Doc PR symfony/symfony-docs#18595

For now this PR just ignores excluded pools/clearers when they don’t exist or wouldn’t be cleared/run anyways. Not sure what the best DX would be 🤔

@carsonbot carsonbot added this to the 6.4 milestone Jul 21, 2023
@MatTheCat MatTheCat force-pushed the exclude_pools_from_clearing branch from a9a13cc to 5126d11 Compare July 21, 2023 09:52
maxbeckers
maxbeckers approved these changes Jul 21, 2023
View reviewed changes
Copy link
Contributor

@maxbeckers maxbeckers left a comment •
edited

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could also be done by not adding it to $pools and $clearers in the loop before instead of this unset solution, but fine for me this way.

Needs a related doc PR to explain the feature in docs.

@MatTheCat MatTheCat mentioned this pull request Jul 21, 2023
Open
@MatTheCat MatTheCat force-pushed the exclude_pools_from_clearing branch from 5126d11 to 39fe666 Compare July 21, 2023 10:20
@nicolas-grekas
Copy link
Member

Please always rebase, we don't accept PRs with merge commits in their history.

@MatTheCat
Copy link
Contributor Author

Sorry, tried to rebase using GitHub UI but it ended in a merge commit 😅
Should be good now.

@chalasr
Copy link
Member

chalasr commented Aug 11, 2023 •
edited

We could deprecate --all and just clear all pools when the pools argument is not specified.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@maxbeckers maxbeckers maxbeckers approved these changes

Assignees
No one assigned
Labels
Feature FrameworkBundle Status: Reviewed
Projects
None yet
Milestone
6.4
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@MatTheCat @nicolas-grekas @chalasr @maxbeckers @carsonbot