Skip to content
Permalink
main
Switch branches/tags

Name already in use

A tag already exists with the provided branch name. Many Git commands accept both tag and branch names, so creating this branch may cause unexpected behavior. Are you sure you want to create this branch?

Commits on Apr 6, 2023

  1. ci: remove lock-closed action (#49650)

    Remove the lock-closed asction as it has been centralized within dev-infra
    
    PR Close #49650
    josephperrott authored and AndrewKushnir committed Apr 6, 2023
  2. docs: Improve previous version navigation (#49063)

    In archive mode the link to the current doc will now point to same page.
    If the page doesn't exist anymore, it will show a contextualized warning message.
    
    See #46850
    
    PR Close #49063
    JeanMeche authored and AndrewKushnir committed Apr 6, 2023
  3. refactor(core): update the link in hydration stats message (#49728)

    Currently, the link points to https://angular.io/guides/hydration and there are 2 issues with it: the `guides/hydration` should actually be `guide/hydration` and the guide is only available at https://next.angular.io, but not at https://angular.io. It will be available at https://angular.io once v16 final is released. For now, we can point to https://next.angular.io, so that developers testing hydration during the pre-release period can follow the link.
    
    PR Close #49728
    AndrewKushnir committed Apr 6, 2023
  4. refactor(core): drop a reference to enableProdMode() in a console.l…

    …og (#49723)
    
    New `ng new` apps no longer generate `enableProdMode` calls when an app is created. The prod mode is enabled via CLI flags (and configuration in the `angular.json` if needed).
    
    PR Close #49723
    AndrewKushnir committed Apr 6, 2023
  5. refactor(core): skip hydration for components that use ShadowDom enca…

    …psulation (#49722)
    
    The Domino DOM emulation library doesn't support shadow DOM. For such components we can not guarantee that client and server representations would match perfectly. To avoid hydration mismatch errors, such components are opted out of hydration.
    
    PR Close #49722
    AndrewKushnir committed Apr 6, 2023
  6. refactor(core): skip hydration for components that use i18n (instead …

    …of throwing an error) (#49722)
    
    Currently, non-destructive hydration for i18n blocks is not supported (but support is coming!).
    This commit updates the serialization logic from throwing an error when it comes across an i18n
    block to annotating a component with a skip hydration flag.
    
    PR Close #49722
    AndrewKushnir committed Apr 6, 2023
  7. refactor(animations): remove #9100 todos. (#49407)

    Breaking change: On `AnimationPlayer.setPosition` the argument is now of type `number`
    
    PR Close #49407
    JeanMeche authored and dylhunn committed Apr 6, 2023

Commits on Apr 5, 2023

  1. refactor(platform-browser): remove deprecated `BrowserTransferStateMo…

    …dule` symbol (#49718)
    
    The `TransferState` class was updated in v14 in a way that the `BrowserTransferStateModule` was no longer required. The `BrowserTransferStateModule` was deprecated in v14.1 and it's currently empty. This commit removes the `BrowserTransferStateModule`.
    
    BREAKING CHANGE: The deprecated `BrowserTransferStateModule` was removed, since it's no longer needed. The `TransferState` class can be injected without providing the module. The `BrowserTransferStateModule` was empty starting from v14 and you can just remove the reference to that module from your applications.
    
    PR Close #49718
    JeanMeche authored and dylhunn committed Apr 5, 2023
  2. refactor(platform-browser): remove empty begin and end methods fr…

    …om renderer (#49630)
    
    This methods are optional and thus not needed to be defined.
    
    PR Close #49630
    alan-agius4 authored and dylhunn committed Apr 5, 2023
  3. refactor(animations): remove Domino specific logic (#49630)

    These workarounds are no longer required following the fixes in angular/domino#14
    
    PR Close #49630
    alan-agius4 authored and dylhunn committed Apr 5, 2023
  4. refactor(platform-server): remove ServerRendererFactory2 and `Emula…

    …tedEncapsulationServerRenderer2` (#49630)
    
    These methods are no longer required following the fixes in angular/domino#14
    
    PR Close #49630
    alan-agius4 authored and dylhunn committed Apr 5, 2023
  5. refactor(platform-browser): update renderer to be able to remove `Ser…

    …verRendererFactory2` and `EmulatedEncapsulationServerRenderer2` (#49630)
    
    This commits updates the render to able to handle the slight differences between platform-server and platform-browser.
    
    This is needed to eventually be able to remove `ServerRendererFactory2` and `EmulatedEncapsulationServerRenderer2` from platform-server.
    
    PR Close #49630
    alan-agius4 authored and dylhunn committed Apr 5, 2023
  6. refactor(core): add explicit import for ngDevMode (#49708)

    This commit adds an explicit import of the ngDevMode definition to the
    files in the signal package which use it.
    
    PR Close #49708
    alxhub authored and dylhunn committed Apr 5, 2023
  7. refactor(core): export additional symbols from the signals index (#49708

    )
    
    This commit adds a few missing exports from the signals index.
    
    PR Close #49708
    alxhub authored and dylhunn committed Apr 5, 2023
  8. refactor(core): add postSignalSetFn hook for WritableSignal (#49708)

    This commit adds a hook to `WritableSignal` that is called whenever the
    signal's value is updated via the mutation API. This hook allows consumers
    to implement logic which is synchronous with signal sets (e.g. executing
    effects). It's currently unused.
    
    PR Close #49708
    alxhub authored and dylhunn committed Apr 5, 2023
  9. build: combine @bazel/concatjs patches (#49714)

    This commit combines all the `@bazel/concatjs` patches
    
    PR Close #49714
    alan-agius4 authored and dylhunn committed Apr 5, 2023
  10. build: update domino digest to aa8de34 (#49716)

    See associated pull request for more information.
    
    PR Close #49716
    angular-robot authored and dylhunn committed Apr 5, 2023
  11. fix(core): make sure that lifecycle hooks are not tracked (#49701)

    Angular lifecycle hooks should never be run as part of the reactive
    context: we do not expect that signal reads in lifecycle hooks
    report to any consumers.
    
    In the current Angular some of the lifecycle hooks can be flushed
    early, while executting template update pass. We need to make sure
    that signal reads in those lifecycle hooks do not register as part
    of the effect that marks components for check.
    "
    
    PR Close #49701
    pkozlowski-opensource authored and dylhunn committed Apr 5, 2023
  12. fix(core): When using setInput, mark view dirty in same was as `markF…

    …orCheck` (#49711)
    
    `ComponentRef.setInput` internally calls `markDirtyIfOnPush` which only marks
    the given view as dirty but does not mark parents dirty like `ChangeDetectorRef.markForCheck` would.
    https://github.com/angular/angular/blob/f071224720f8affb97fd32fb5aeaa13155b13693/packages/core/src/render3/instructions/shared.ts#L1018-L1024
    
    `markDirtyIfOnPush` has an assumption that it’s being called from the parent’s template. That is, we don’t need to mark dirty to the root, because we’ve already traversed down to it.
    The function used to only be called during template execution for input
    bindings but was added to `setInput` later. It's not a good fit because
    it means that if you are responding to events such as an emit from an `Observable`
    and call `setInput`, the view of your `ComponentRef` won't necessarily get checked
    when change detection runs next. If this lives inside some `OnPush` component tree
    that's not already dirty, it only gets refreshed if you also call
    `ChangeDetectorRef.markForCheck` in the host component (because it will be "shielded" be a non-dirty parent).
    
    PR Close #49711
    atscott authored and dylhunn committed Apr 5, 2023
  13. feat(core): support usage of non-experimental decorators with TypeScr…

    …ipt 5.0 (#49492)
    
    Previously, attempting to turn off the `experimentalDecorators` TypeScript configuration
    option within an Angular project would result in build time errors. These errors were due
    to an exposed Decorator signature from `@angular/core` that TypeScript thought was incompatible
    with standard decorators. However, Angular's class decorators (`Component`, `Directive`, `Pipe`,
    `Injectable`, `NgModule`) are actually already compatible with standard decorators. The export types for
    the decorators only needed to be updated to reflect that compatibility. With the updated exported types,
    applications will now successfully compile and execute in AOT mode with one important dependency injection
    caveat explained in the note below.
    For JIT mode applications that are built with the Angular CLI, `@ngtools/webpack`, or use `tsickle`,
    there were also no additional changes required. These tools automatically convert property decorators
    (now called field decorators) at build time to store Angular property metadata directly on the relevant
    class. Building with these tools is the overwhelmingly common method of building an application. Any
    applications that do not use one of these tools will not function at runtime in JIT mode if using standard
    decorators. The behavior and code for when experimental decorators is enabled has been left intact.
    
    NOTE: Angular constructor dependency injection that requires parameter decorators is not supported.
    The standard decorator specification does not support parameter decorators. The `inject` function must be
    used for all cases that previously required a parameter decorator. This includes such decorators as `Inject`,
    `Optional`, `Self`, `SkipSelf`, `Host`, and `Attribute`. Constructor dependency injection that relies only
    on the supplied parameter type will continue to function as expected if using AOT; as well as in JIT mode
    if using the Angular CLI, `@ngtools/webpack` directly, or `tsickle`.
    
    Documentation for the `inject` function can be found at: https://angular.io/api/core/inject
    The decorator specification proposal can be found at: https://github.com/tc39/proposal-decorators
    
    PR Close #49492
    clydin authored and dylhunn committed Apr 5, 2023
  14. refactor(core): Use the nullish coalescing assignment in render3 func…

    …tions (#49698)
    
    The usage of `??=` make the code more clear & concise.
    
    PR Close #49698
    JeanMeche authored and dylhunn committed Apr 5, 2023
  15. refactor(forms): Add a test that uses ControlConfig with a non-static…

    … validator. (#49693)
    
    Previously, this PR cleaned up a bug introduced by #48679. However, since that PR needed to be rolled back, this PR now just checks in the test, to prevent that issue from re-occurring in the future.
    
    PR Close #49693
    dylhunn committed Apr 5, 2023

Commits on Apr 4, 2023

  1. refactor(core): Remove ReflectiveInjector symbol (#48103)

    The `ReflectiveInjector` symbol has been deprecated in v5 (11 major versions ago). This commit removes ReflectiveInjector and related symbols.
    
    BREAKING CHANGE: The `ReflectiveInjector` and related symbols were removed. Please update the code to avoid references to the `ReflectiveInjector` symbol. Use `Injector.create` as a replacement to create an injector instead.
    
    PR Close #48103
    JeanMeche authored and dylhunn committed Apr 4, 2023
  2. build: update eslint dependencies to v5.57.1 (#49696)

    See associated pull request for more information.
    
    PR Close #49696
    angular-robot authored and dylhunn committed Apr 4, 2023
  3. refactor(core): Cleanup for Iterable differs test. (#49598)

    Remove some `any` and use the non-deprecated `Injector.create` overload.
    
    PR Close #49598
    JeanMeche authored and dylhunn committed Apr 4, 2023
  4. feat(core): Drop public factories property for IterableDiffers : …

    …Breaking change (#49598)
    
    The `factories` property was marked as deprecated in v4 to make it private. Let's move it to private.
    
    PR Close #49598
    JeanMeche authored and dylhunn committed Apr 4, 2023
  5. refactor(router): Remove RouterTestingModule in favor of RouterModule…

    ….forRoot (#49427)
    
    `RouterTestingModule` is not needed as of v16. Instead, TestBed
    automatically provides `MockPlatformLocation` in order to help test
    navigations in the application. The location mocks in the
    RouterTestingModule aren't necessary anymore.
    
    There doesn't appear to be any real documentation around
    `RouterTestingModule` other than the API docs.
    
    PR Close #49427
    atscott authored and dylhunn committed Apr 4, 2023
  6. refactor(zone.js): remove #9100 todos. (#49409)

    This commit assigns the correct type instead of `any`.
    
    PR Close #49409
    JeanMeche authored and dylhunn committed Apr 4, 2023
  7. refactor(core): remove ɵmakeDecorator from private exports (#49300)

    `makeDecorator` is unused outside of core and is not part of the public API (not exported).
    
    PR Close #49300
    JeanMeche authored and dylhunn committed Apr 4, 2023
  8. fix(router): create correct URL relative to path with empty child (#4…

    …9691)
    
    The previous fix for squashing empty children didn't quite work when the
    existing route had segments. The result would be that the segments from
    the existing route were dropped from the final URL.
    
    PR Close #49691
    atscott authored and dylhunn committed Apr 4, 2023
  9. build: update domino digest to 89bec1a (#49703)

    See associated pull request for more information.
    
    PR Close #49703
    angular-robot authored and dylhunn committed Apr 4, 2023
Older