-
Notifications
You must be signed in to change notification settings - Fork 19.9k
-determiant of a matrix (modified ) #4221
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please replace tabs with spaces, remove main(), and add JUnit tests if there are none
Build got passed ,I have included test file to,help me with formatting ,I have converted tab to spaces but not working............. |
I have cleared those tab spaces still!!!! please guide me! |
Please see the running log in https://github.com/TheAlgorithms/Java/actions/runs/5376950008/jobs/9754791549 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add this formula in a separate file because it's different from the one in DeterminantOfMatrix or rename the original one to Naive
and yours to Cramers
if it's that
This pull request has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions. |
Please reopen this pull request once you commit the changes requested or make improvements on the code. If this is not the case and you need some help, feel free to seek help from our Gitter or ping one of the reviewers. Thank you for your contributions! |
---increased modularity by splitting up the code into three functions based on logic.
---increased the scalability of code as now it could work on numbers with any digits including decimals ,negative numbers.
---enhanced the readability by following Cofactor expansion method which is simple to implement and easy to understand.(the algorithm is attached as a link)