Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

perf maps address format #103650

Closed
art049 opened this issue Apr 20, 2023 · 2 comments
Closed

perf maps address format #103650

art049 opened this issue Apr 20, 2023 · 2 comments
Labels
3.12 new features, bugs and security fixes 3.13 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error

Comments

@art049
Copy link
Contributor

art049 commented Apr 20, 2023 •
edited

Bug report

As implemented by @pablogsal in #96123 we can now generate perf maps(which is awesome BTW).
Currently, perf maps are formatted this way:

0x58c5882 b py::<module>:/home/arthur/Projects/python-playground/dummy_script.py
0x58c588d b py::baz:/home/arthur/Projects/python-playground/dummy_script.py
0x58c5898 b py::bar:/home/arthur/Projects/python-playground/dummy_script.py
0x58c58a3 b py::foo:/home/arthur/Projects/python-playground/dummy_script.py

However, as per the perf maps interface specification it seems the address should not include the leading 0x.

Thus the perf map should look like this:

58c5882 b py::<module>:/home/arthur/Projects/python-playground/dummy_script.py
58c588d b py::baz:/home/arthur/Projects/python-playground/dummy_script.py
58c5898 b py::bar:/home/arthur/Projects/python-playground/dummy_script.py
58c58a3 b py::foo:/home/arthur/Projects/python-playground/dummy_script.py

Still, it works fine with perf but might not with other tools not handling this leading 0x.

Your environment

  • CPython versions tested on: 3.12.0a7
  • Operating system and architecture: Manjaro 22.1.0 x86_64

Linked PRs
@art049 art049 added the type-bug An unexpected behavior, bug, or error label Apr 20, 2023
@art049 art049 mentioned this issue Apr 20, 2023
Merged
@arhadthedev arhadthedev added 3.12 new features, bugs and security fixes 3.13 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) labels Apr 20, 2023
@terryjreedy
Copy link
Member

@pablogsal The perf doc says that perf map start addresses (as well as sizes) are hex numbers without '0x'. The implementation prints them with '0x'. Which is wrong? There is a PR to change the implementation.

pablogsal pushed a commit that referenced this issue May 7, 2023
@art049
gh-103650: Fix perf maps address format (#103651)
8d95012
@hauntsaninja
Copy link
Contributor

Closing since #103651 was merged

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
3.12 new features, bugs and security fixes 3.13 new features, bugs and security fixes interpreter-core (Objects, Python, Grammar, and Parser dirs) type-bug An unexpected behavior, bug, or error
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
4 participants
@arhadthedev @hauntsaninja @art049 @terryjreedy