Fix CookieJar + OpenerDirector interactions and UnhandledExceptionWarning #106925
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If you run the following code against an http server that returns cookies...
You may / will experience the following warning + unhandled exception:
Attempting to play whack-a-mole will make you realize that the cookiejar really wants a
BaseRequest
, not anOpenerDirector
, so we proxy the request data via__getattr__
, removing the warning.When I run this to verify the patch locally, I no longer experience the issue in Python 3.11 installs: