-
-
Notifications
You must be signed in to change notification settings - Fork 32.1k
gh-107559: Argument Clinic: complain about non-ascii chars in param docstrings #107560
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-107559: Argument Clinic: complain about non-ascii chars in param docstrings #107560
Conversation
…aram docstrings Also, improve the warn() message.
Do you want to backport this? |
Lib/test/test_clinic.py
Outdated
with support.captured_stdout() as stdout: | ||
self.parse(block) | ||
# Only the first match is shown. | ||
# Also, the line numbers are off; this is a known limitation. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's try to address that limitation in the error handling rewrite.
I'll leave it to you to decide — it's strictly speaking a bugfix, so we could, but it's also a bug that people are pretty unlikely to hit in practice (and I don't know how many people actually use clinic from older branches of CPython anyway...). So maybe not worth the churn. |
We'll see if 🧙♀️ can handle it. If she can't, we won't bother. |
Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12. |
Sorry, @erlend-aasland, I could not cleanly backport this to |
Sorry, @erlend-aasland, I could not cleanly backport this to |
Also, improve the warn() message.