Skip to content

[Serializer] Do not trigger deprecation when calling from Symfony code #51280

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

[Serializer] Do not trigger deprecation when calling from Symfony code #51280

wants to merge 1 commit into from

Conversation

wouterj
Copy link
Member

@wouterj wouterj commented Aug 5, 2023

Q A
Branch? 6.3
Bug fix? yes
New feature? no
Deprecations? no
Tickets Fix #51277
License MIT
Doc PR -

@wouterj wouterj requested a review from dunglas as a code owner August 5, 2023 10:08
@carsonbot carsonbot added this to the 6.3 milestone Aug 5, 2023
@wouterj wouterj linked an issue Aug 5, 2023 that may be closed by this pull request
ObjectNormalizer::hasCacheableSupportsMethod()" method is deprecated, use "getSupportedTypes()" instead. #51277
Closed
@nicolas-grekas
Copy link
Member

Not sure about this, see #51277 (comment)
I'd like to better understand what's going on for the reporter.

@nicolas-grekas
Copy link
Member

Maybe we can improve the deprecation message instead, telling to implement getSupportedTypes() when it's not there (and give the name of the $this class to hint about where this should be added.)

@nicolas-grekas nicolas-grekas mentioned this pull request Aug 5, 2023
Merged
@nicolas-grekas
Copy link
Member

Closing in favor of #51288, thanks for giving this a try!

nicolas-grekas added a commit that referenced this pull request Aug 7, 2023
@nicolas-grekas
minor #51288 [Serializer] Make deprecation message more actionable (n…
785b66a 
…icolas-grekas)

This PR was merged into the 6.3 branch.

Discussion
----------

[Serializer] Make deprecation message more actionable

| Q             | A
| ------------- | ---
| Branch?       | 6.3
| Bug fix?      | no
| New feature?  | no
| Deprecations? | no
| Tickets       | Fix #51277
| License       | MIT
| Doc PR        | -

Instead of #51280

Commits
-------

9f86e7f [Serializer] Make deprecation message more actionable
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dunglas dunglas Awaiting requested review from dunglas dunglas is a code owner

Assignees
No one assigned
Labels
Bug Serializer Status: Needs Review
Projects
None yet
Milestone
6.3
Development

Successfully merging this pull request may close these issues.

ObjectNormalizer::hasCacheableSupportsMethod()" method is deprecated, use "getSupportedTypes()" instead.
3 participants
@wouterj @nicolas-grekas @carsonbot