gh-59330: argparse: Properly handle positional arguments containing '-' #104092
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
furkanonder
changed the title
| @@ -1577,6 +1587,9 @@ def _get_positional_kwargs(self, dest, **kwargs): | |||
| if kwargs.get('nargs') == ZERO_OR_MORE and 'default' not in kwargs: | |||
| kwargs['required'] = True | |||
|
|
|||
| # make dest attribute-accessible, 'foo-bar' -> 'foo_bar' | |||
| dest = dest.replace('-', '_') | |||
There was a problem hiding this comment.
It has a side effect of changing the default metavar.
| return key in self.__dict__ or key.replace('-', '_') in self.__dict__ | ||
|
|
||
| def __getattr__(self, name): | ||
| # Compatibility for people doing getattr(args, 'foo-bar') instead of |
There was a problem hiding this comment.
But what about setattr(args, 'foo-bar') and delattr(args, 'foo-bar')?
| @@ -0,0 +1 @@ | |||
| Hyphens in positional arguments in argparse module are automatically replaced with underscores. Patch by Simon Law and Furkan Onder. | |||
There was a problem hiding this comment.
It should be in the Library section.
AlexWaygood
changed the title
|
Close this PR as it is too complex and may still break user code. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Co-authored by: Simon Law