New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Replace num-bigint with malachite-bigint #4952
Conversation
b130f6b
to
d7c0f0f
Compare
This comment has been hidden.
This comment has been hidden.
33f603a
to
f0b5203
Compare
f0b5203
to
8839b1b
Compare
9676f6e
to
7737709
Compare
|
Don't change bytes_to_int, malachite-bigint should handle it. I think it is a bug involved on the last commit |
a230959
to
8ce6240
Compare
@qingshi163 Can we run a benchmark about this? A benchmark with many small int binary operations will fit. |
@youknowone @qingshi163
import pyperf
runner = pyperf.Runner()
runner.timeit(name="bench fib",
stmt="""
_ = fib(10)
""",
setup = """
def fib(n):
if n == 0:
return 0
if n == 1 or n == 2:
return 1
return fib(n-1) + fib(n-2)
""") |
@corona10 Thank you! |
b5af178
to
91803f9
Compare
91803f9
to
137aa70
Compare
hmm, this is unexpected. what's changed? |
I can't locally reproduce it. |
ah, main is already broken |
c9ebd2f
to
137aa70
Compare
No description provided.