Skip to content

feat : Program to find Kth Symbol of Grammar #1326

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from
Closed

feat : Program to find Kth Symbol of Grammar #1326

wants to merge 2 commits into from

Conversation

hecker1002
Copy link

@hecker1002 hecker1002 commented May 25, 2023

Open in Gitpod know more

Describe your change:

  • Add an algorithm?
  • Fix a bug or typo in an existing algorithm?
  • Documentation change?

Checklist:

  • I have read CONTRIBUTING.md.
  • This pull request is all my own work -- I have not plagiarized.
  • I know that pull requests will not be merged if they fail the automated tests.
  • This PR only changes one algorithm file. To ease review, please open separate PRs for separate algorithms.
  • All new JavaScript files are placed inside an existing directory.
  • All filenames should use the UpperCamelCase (PascalCase) style. There should be no spaces in filenames.
    Example:UserProfile.js is allowed but userprofile.js,Userprofile.js,user-Profile.js,userProfile.js are not
  • All new algorithms have a URL in their comments that points to Wikipedia or another similar explanation.
  • If this pull request resolves one or more open issues then the commit message contains Fixes: #{$ISSUE_NO}.

Copy link
Collaborator

@appgurueu appgurueu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Missing proper tests, CI is failing.

@@ -14,5 +14,5 @@ export function TowerOfHanoi (n, from, to, aux, output = []) {

// Driver code (A, C, B are the name of rods)

// const n = 4
// TowerOfHanoi(n, 'A', 'C', 'B')
const n = 4
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Unrelated change.

}

// Enter the row no. and col no. of matrix
let ans = KSymbol( 4, 1)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This should be in a test I assume.

// 0 1 1 0 1 0 0 1
// 0 1 ,.....

function KSymbol(n ,k){
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

needs more comments, also doesn't abide by our style guidelines

@@ -0,0 +1,32 @@
// Recursive call function to find l=k th Symbol of Grammar (0 => 0,1 , 1=> 1,0)
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please rephrase this

@Mohammed-Faizzzz
Copy link

Hi, may I check if help is still required? Please let me know, I would be very much willing to help!

@appgurueu
Copy link
Collaborator

Hi, may I check if help is still required? Please let me know, I would be very much willing to help!

Well, the issues still haven't been resolved.

@stale
Copy link

stale bot commented Jun 18, 2023

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

@stale stale bot added the stale Closed due to age label Jun 18, 2023
@hecker1002 hecker1002 closed this by deleting the head repository Jan 27, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
stale Closed due to age
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants