Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

reorg Advanced guides #272

Merged
merged 12 commits into from Aug 21, 2020
Merged

reorg Advanced guides #272

merged 12 commits into from Aug 21, 2020

Conversation

sw-yx
Copy link
Collaborator

@sw-yx sw-yx commented Aug 20, 2020

i've renamed the "guides" in the Advanced section to "Patterns by Usecase" which is hopefully a more intuitive name. I've never liked the split into many little pages - scrolling is better than clicking - so i put them all on one page

I've also added notes on typing children as this is a super common qtn, relevant to #271

did other minor reorgs as well.

happy to take comments, you can see the deploy preview here https://5f3ea3b1edd4d10009ba4118--react-typescript-cheatsheet.netlify.app/
image

@with-heart
Copy link
Contributor

with-heart commented Aug 20, 2020

Scrolling is definitely nicer than a bunch of mini pages. Solid improvement 👍

Copy link
Collaborator

@ferdaber ferdaber left a comment

I like this!

@sw-yx
Copy link
Collaborator Author

sw-yx commented Aug 21, 2020

🚢

@sw-yx sw-yx merged commit d467788 into master Aug 21, 2020
6 checks passed
@sw-yx sw-yx deleted the reorganizeAdvancedGuides branch Aug 21, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants