Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix docs build #10566

Merged
merged 1 commit into from Aug 5, 2022
Merged

Fix docs build #10566

merged 1 commit into from Aug 5, 2022

Conversation

kurkle
Copy link
Member

@kurkle kurkle commented Aug 5, 2022

https://github.com/chartjs/Chart.js/actions/runs/2800072306

Findings:

  • The action was not updated
  • VuePress does not support config.cjs or config.js as ESM
  • VuePress 1.9 supports config.ts
  • The typings of the VuePress configuration did not allow everything we had, so there are some ugly workarounds (due to limited time).
  • Braces in typescript comments can probably break somethining in docs, as typedoc warns about those, that's the reason for types/index.d.ts changes.

@kurkle kurkle added this to the Version 4.0 milestone Aug 5, 2022
LeeLenaleee
LeeLenaleee reviewed Aug 5, 2022
View changes
Copy link
Collaborator

@LeeLenaleee LeeLenaleee left a comment •
edited

Docs still seem to build incorrectly, there is no navigation showing or sidebar.
Also seems like the theme is not applying anymore, anchor tags and clickable text color is green instead of blue and the font weight of the title is lower as before.

EDIT:
MB forgot to run npm install to update packages, seems to work fine

docs/.vuepress/config.ts Show resolved Hide resolved
docs/.vuepress/config.ts Show resolved Hide resolved
@etimberg etimberg merged commit 29395d9 into chartjs:master Aug 5, 2022
9 checks passed
@kurkle kurkle deleted the fix-docs-build branch Aug 5, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@etimberg etimberg

@LeeLenaleee LeeLenaleee

Assignees
No one assigned
Labels
type: documentation type: infrastructure
Projects
None yet
Milestone
Version 4.0
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@kurkle @etimberg @LeeLenaleee