Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(electron): work on node envioronments #1780

Merged
merged 12 commits into from Mar 14, 2022
Merged

feat(electron): work on node envioronments #1780

merged 12 commits into from Mar 14, 2022

Conversation

posva
Copy link
Member

@posva posva commented Mar 9, 2022

This adds the support to the electron shell for node by having a different build with webpack that targets node.

Another possible solution would be to use isomorphic-ws to make it work with one build but:

Left to be done:

  • Some of the changes of window to target might not be necessary
  • Hide buttons like scroll to component and inspect dom in node build

Akryum added 2 commits Mar 14, 2022
Conflicts:
	packages/app-backend-core/src/timeline.ts
@Akryum Akryum changed the title feat(shell-electron): work on node envioronments feat(electron): work on node envioronments Mar 14, 2022
@Akryum Akryum merged commit b50e994 into main Mar 14, 2022
5 of 6 checks passed
@Akryum Akryum deleted the wip/socket branch Mar 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants