Support "bpo-" in Misc/NEWS #1

brettcannon · 2017-02-10T22:41:57Z

No description provided.

Carreau · 2017-02-10T22:44:39Z

Doc/tools/extensions/pyspecific.py

@@ -253,7 +253,7 @@ def run(self):
            text = 'The NEWS file is not available.'
            node = nodes.strong(text, text)
            return [node]
-        content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__',
+        content = issue_re.sub(r'`\bpo-\2 <https://bugs.python.org/\2>`__',


\b ? I think you overwrote the \1 :-)

That's on purpose as the first capture group is the prefix which doesn't matter. Probably should change the regex to use a non-capture group.

Sure, you can either you use \1 or insert bpo-. But here you overwrote half the capture group by only deleting the 1 and not the \.

Ah, you're right. Now fixed.

Make the prefix match non-capturing and fix a bug where a backslash was left into the substitution.

zware · 2017-02-10T22:59:44Z

Doc/tools/extensions/pyspecific.py

@@ -34,7 +34,7 @@


 ISSUE_URI = 'https://bugs.python.org/issue%s'
-SOURCE_URI = 'https://hg.python.org/cpython/file/3.6/%s'
+SOURCE_URI = 'https://github.com/python/cpython/tree/3.6/%s'


Shouldn't it be master rather than 3.6 on this branch?

My patch for another issue will address this, I think 🤔

http://bugs.python.org/file45904/issue28941.patch

I went ahead and updated here since I'm already changing it.

zware · 2017-02-10T23:01:03Z

Doc/tools/extensions/pyspecific.py

@@ -253,7 +253,7 @@ def run(self):
            text = 'The NEWS file is not available.'
            node = nodes.strong(text, text)
            return [node]
-        content = issue_re.sub(r'`\1ssue #\2 <https://bugs.python.org/\2>`__',
+        content = issue_re.sub(r'`bpo-\1 <https://bugs.python.org/\1>`__',


I'd suggest making it https://bugs.python.org/issue\1 to avoid the redirect through https://www.python.org/sf/

(cherry picked from commit 79ab8be)

Change the url to 3.5 (cherry picked from commit 79ab8be) # Conflicts: # Doc/tools/extensions/pyspecific.py

Change the url to 2.7 (cherry picked from commit 79ab8be)

…#44) * Support "bpo-" in Misc/NEWS (#1) Change the url to 2.7 (cherry picked from commit 79ab8be) * pyspecific.py: remove space after` bpo-`

Change the url to 3.5 (cherry picked from commit 79ab8be) Contributed by Brett Cannon

* Added support for CAN_ISOTP protocol * Added unit tests for CAN ISOTP * Updated documentation for ISO-TP protocol * Removed trailing whitespace in documentation * Added blurb NEWS.d file * updated Misc/ACKS * Fixed broken unit test that was using isotp const outside of skippable section * Removed dependecy over third party project * Added implementation for getsockname + unit tests * Missing newline at end of ACKS file * Accidentally inserted a type in ACKS file * Followed tiran changes review #1 recommendations * Added spaces after comma

python#7287 (comment)

Create a webservice that receives the GitHub Webhook events.

Restoring the original shar contents

#108688) This reverts commit 08447b5. Revert also _ctypes.c changes of the PyDict_ContainsString() change, commit 6726626.

miss-islington · 2023-10-11T08:36:16Z

Thanks @Mariatta for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington · 2023-10-11T08:36:18Z

Sorry, @Mariatta, I could not cleanly backport this to 3.12 due to a conflict.
Please backport using cherry_picker on command line.

cherry_picker ea7f2d70b8a870d3f1e5c0fed442a393a96d4695 3.12

Hijacked the interpreter state to get my boys on the inside. Currently, there doesn't seem to be an officially supported way to get a piece of pre-initialized per-interpreter memory over to an embedded module (more specifically, the embedded module's functions). For example: [init'd mem python#1] ----> [subinterp python#1] ----> {module fn call} [init'd mem python#2] ----> [subinterp python#2] ----> {module fn call} {module fn call} has a single implementation with access to its module state via \`PyModule_GetState\`. The initialization of a subinterpreter populates a custom entry for the pre-initialized memory in its interpreter state. On initialization of the embedded module (\`Py_mod_exec\`), the module state is populated with the custom entry (\`PyThreadState_Get()->interp\`). The module function now has access to the pre-initialized memory via its module state.

Hijacked the interpreter state to get my boys on the inside. Currently, there doesn't seem to be an officially supported way to get a piece of pre-initialized per-interpreter memory over to an embedded module (more specifically, the embedded module's functions). For example: [init'd mem python#1] ----> [subinterp python#1] ----> {module fn call} [init'd mem python#2] ----> [subinterp python#2] ----> {module fn call} {module fn call} has a single implementation with access to its module state via `PyModule_GetState`. The initialization of a subinterpreter populates a custom entry for the pre-initialized memory in its interpreter state. On initialization of the embedded module (`Py_mod_exec`), the module state is populated with the custom entry (`PyThreadState_Get()->interp`). The module function now has access to the pre-initialized memory via its module state.

Support "bpo-" in Misc/NEWS

1900740

the-knights-who-say-ni added the CLA signed label Feb 10, 2017

Carreau reviewed Feb 10, 2017

View reviewed changes

Fix up the match and substitution regexes

5401164

Make the prefix match non-capturing and fix a bug where a backslash was left into the substitution.

Carreau approved these changes Feb 10, 2017

View reviewed changes

zware reviewed Feb 10, 2017

View reviewed changes

Address reviewer comments

02a87ce

zware approved these changes Feb 10, 2017

View reviewed changes

zware merged commit 79ab8be into master Feb 10, 2017

brettcannon deleted the bpo-news-support branch February 10, 2017 23:10

Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017

Support "bpo-" in Misc/NEWS (#1)

98cb83e

(cherry picked from commit 79ab8be)

Mariatta mentioned this pull request Feb 12, 2017

[backport to 3.6] Bpo news support 3.6 #42

Merged

Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017

Support "bpo-" in Misc/NEWS (#1)

73e2903

Change the url to 3.5 (cherry picked from commit 79ab8be) # Conflicts: # Doc/tools/extensions/pyspecific.py

Mariatta referenced this pull request in Mariatta/cpython Feb 12, 2017

Support "bpo-" in Misc/NEWS (#1)

63b8f25

Change the url to 2.7 (cherry picked from commit 79ab8be)

Mariatta added a commit that referenced this pull request Feb 13, 2017

Support "bpo-" in Misc/NEWS (#1) (#43)

af456b2

Change the url to 3.5 (cherry picked from commit 79ab8be) Contributed by Brett Cannon

csabella mentioned this pull request Dec 22, 2017

bpo-20285: Improve help docs for object #4759

Merged

bapt mentioned this pull request Jan 18, 2018

bpo-32593: distutils UnixCCompiler: remove FreeBSD special case #5233

Closed

native-api pushed a commit to native-api/cpython that referenced this pull request Jun 5, 2018

Merge pull request python#1 from native-api/roseman_1

9a5b0e8

python#7287 (comment)

Clucier17 reviewed Jul 28, 2018

View reviewed changes

aixtools mentioned this pull request Oct 26, 2018

bpo-1154351: Add get_current_dir_name() to os module #10117

Closed

brianquinlan mentioned this pull request May 8, 2019

bpo-31783: Fix a race condition creating workers during shutdown #13171

Merged

tim-one mentioned this pull request May 29, 2019

bpo-37029: keep usable_arenas in sorted order without searching #13612

Merged

ElizabethU mentioned this pull request Jul 20, 2019

bpo-37555: Update _CallList.__contains__ to respect ANY #14700

Merged

btharper mentioned this pull request Oct 6, 2019

bpo-36356: Fix memory leak in _asynciomodule.c during "setup.py build_ext" #16598

Merged

jaraco pushed a commit that referenced this pull request Dec 2, 2022

Initial commit of Python cherry-picker bot (#1)

e728050

Create a webservice that receives the GitHub Webhook events.

fabiounixpi mentioned this pull request Dec 13, 2022

FAIL: test_quickened_static_code_gets_unquickened_at_Py_FINALIZE #100225

Open

terryjreedy mentioned this pull request Dec 20, 2022

IDLE needs syntax highlighting for f-strings #73473

Open

ghost mentioned this pull request Dec 29, 2022

Cpython compilation time test_hashlib fail #100604

Closed

Lagunaxx mentioned this pull request Jan 7, 2023

possible memory access corruption #100822

Closed

elcouz mentioned this pull request Jan 21, 2023

Unknown float word ordering with ./configure #101224

Closed

corona10 mentioned this pull request Feb 14, 2023

Refleak in test_importlib on aarch64 RHEL8 #101766

Closed

itachaaa mentioned this pull request May 26, 2023

Potential memory leak from TextIOWrapper which would hold unnecessary number of arenas #104954

Open

alisacorporation mentioned this pull request Jun 5, 2023

arch linux python 2 install test socket fail #105336

Closed

eshkrig mentioned this pull request Jun 9, 2023

A bug in the multiprocessing module #82376

Open

t-wy pushed a commit to t-wy/cpython-past-branches that referenced this pull request Jun 17, 2023

Merge pull request python#1 from Ringdingcoder/original

4bcf2ce

Restoring the original shar contents

johentsch mentioned this pull request Jun 26, 2023

asdict() on dataclass with defaultdict raises TypeError: "first argument must be callable or None " #106113

Closed

ghost mentioned this pull request Jul 17, 2023

Pip crash in python3.12 #106824

Closed

hetmankp mentioned this pull request Aug 9, 2023

Surprising behaviour with compileall -s STRIPDIR parameter #105931

Closed

gvanrossum mentioned this pull request Aug 22, 2023

heap-use-after-free in _PyFunction_LookupByVersion #108253

Closed

ambv pushed a commit that referenced this pull request Sep 4, 2023

Revert "gh-46376: Return existing pointer when possible in ctypes (#1… (

5a79d2a

#108688) This reverts commit 08447b5. Revert also _ctypes.c changes of the PyDict_ContainsString() change, commit 6726626.

sobolevn mentioned this pull request Sep 5, 2023

Add modern alternatives to inspect module, deprecate old incorrect APIs #108901

Open

vstinner mentioned this pull request Sep 29, 2023

Support python -Xcpu_count=<n> feature for container environment. #109595

Closed

miss-islington assigned Mariatta Oct 11, 2023

hablahblahha mentioned this pull request Oct 18, 2023

Variables not being set in defines #111030

Closed

LinanV mentioned this pull request Oct 23, 2023

Objects/typeobject.c: No such file or directory. #111203

Closed

stasos24 mentioned this pull request Oct 24, 2023

Modules/cjkcodecs/_codecs_iso2022.c - read out of bounds #101180

Closed

williamhu020 mentioned this pull request Nov 5, 2023

Use the API C of 'Py-NewInterpreterFromConfig' to exit unexpectedly in multiple threads. #111751

Closed

owillebo mentioned this pull request Nov 15, 2023

gh-61215: New mock to wait for multi-threaded events to happen #16094

Merged

kcatss mentioned this pull request Nov 15, 2023

Use-after-free in unregister() of atexit module #112127

Open

ChuBoning mentioned this pull request Nov 20, 2023

deadlocked child process after forking on pystate.c's HEAD_LOCK #112275

Open

Support "bpo-" in Misc/NEWS #1

Support "bpo-" in Misc/NEWS #1

brettcannon commented Feb 10, 2017

Carreau Feb 10, 2017

brettcannon Feb 10, 2017

Carreau Feb 10, 2017

brettcannon Feb 10, 2017

zware Feb 10, 2017

Mariatta Feb 10, 2017

brettcannon Feb 10, 2017

Mariatta Feb 10, 2017

zware Feb 10, 2017

brettcannon Feb 10, 2017

miss-islington commented Oct 11, 2023

miss-islington commented Oct 11, 2023

Support "bpo-" in Misc/NEWS #1

Support "bpo-" in Misc/NEWS #1

Conversation

brettcannon commented Feb 10, 2017

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

Choose a reason for hiding this comment

miss-islington commented Oct 11, 2023

miss-islington commented Oct 11, 2023