golangci / golangci-lint Public
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add execinquery linter #2677
Add execinquery linter #2677
Conversation
Hey, thank you for opening your first Pull Request ! |
Thanks for contributing. I commented nits. |
Could you rebase your PR? Thanks. |
Sorry, I don't get the meaning. |
can you rebase your branch (related to your Pull Request) on the branch
nope, rebase means just rebase example:
|
Thanks, i got it. |
I will rebase your branch because I feel that you need help. (rebase != merge) |
Your tag (v1.0) is not valid from the point of view of Go, can you create a valid tag (v1.0.0)? can you also fix the name of your analyzer? |
Thanks a lot! |
I added new 'v1.0.0' tag and Fix analyzer name |
Can you update go modules ? Because this PR has used incorrect tag version's linter, yet. |
For your information:
|
Thanks for sharing your best solution about dependence. |
Thanks @ldez . |
execinquery is a linter that detects query at database/sql package Query function.
in detail, please check following link.
https://github.com/lufeee/execinquery