Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

docs: update "Shell Completion" instruction on Linux #2829

Merged

Conversation

JohnTitor
Copy link
Contributor

@JohnTitor JohnTitor commented May 6, 2022

When I tried to enable shell autocompletion reading the website, noticed the content on kubernetes.io had been moved. After some playing, I also noticed the golangci-lint completion $SHELL --help command exists and it has a straightforward instruction.
This replaces that link with the command above. I'm open to update the link to https://kubernetes.io/docs/tasks/tools/install-kubectl-linux/#enable-shell-autocompletion, which is the new location of kubectl's instruction, if you'd like.

(I haven't removed the macOS's instruction in case it's still useful.)

@boring-cyborg
Copy link

@boring-cyborg boring-cyborg bot commented May 6, 2022

Hey, thank you for opening your first Pull Request !

@CLAassistant
Copy link

@CLAassistant CLAassistant commented May 6, 2022

CLA assistant check
All committers have signed the CLA.

@ldez ldez changed the title Update "Shell Completion" instruction on Linux docs: update "Shell Completion" instruction on Linux May 6, 2022
@ldez ldez added enhancement area: docs labels May 6, 2022
@JohnTitor

This comment has been hidden.

ldez
ldez approved these changes May 6, 2022
Copy link
Member

@ldez ldez left a comment

LGTM

@ldez ldez merged commit 7c1d8b7 into golangci:master May 8, 2022
16 checks passed
@JohnTitor JohnTitor deleted the fix-shell-completion-link-for-linux branch May 8, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
area: docs enhancement
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants