feat: enable override coloring based on CLICOLOR and CLICOLOR_FORCE #2657
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey, thank you for opening your first Pull Request ! |
|
|
ldez
changed the title
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
some CI runners does not support TTY, like gitlab runner.
related issue https://gitlab.com/gitlab-org/gitlab-runner/-/issues/2115
https://gitlab.com/gitlab-org/gitlab/-/issues/28598
even with
golangci-lint run -v --color always, we can not make the log level support color.with this option, one can set env var
CLICOLOR_FORCE=1to skip the tty check and print colored log level.and set env var
CLICOLOR_FORCE=0andCLICOLOR=0to disable colored log level.see https://github.com/sirupsen/logrus/blob/85981c045988a3ebe607e2f5b8a6499d86e0ddac/text_formatter.go#L120