Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

bump github.com/kulti/thelper from 0.5.1 to 0.6.2 #2742

Merged
merged 1 commit into from Apr 7, 2022

Conversation

kulti
Copy link
Contributor

@kulti kulti commented Apr 3, 2022

In this release, I've added fuzzing test support.

kulti/thelper@v0.5.1...v0.6.2

@kulti
Copy link
Contributor Author

@kulti kulti commented Apr 3, 2022

Well, as I understand go 1.18 required to pass golangci-lint for new version of linter. So, this PR should be postponed due fix of #2649.

@ldez ldez self-requested a review Apr 3, 2022
@ldez ldez added linter: update version blocked labels Apr 3, 2022
@ldez
Copy link
Member

@ldez ldez commented Apr 3, 2022

I'll add some commits to your PR to try something, if it doesn't work I'll remove them.

@ldez
Copy link
Member

@ldez ldez commented Apr 3, 2022

@kulti can you continue to use types.NewSignature instead of types.NewSignatureType like that your linter will pass the go1.17 build and tests?

I know that types.NewSignature is deprecated in go1.18.

https://github.com/golangci/golangci-lint/runs/5806544857?check_suite_focus=true

@kulti kulti force-pushed the bump-thelper-v0.6.0 branch from 8dc36dc to 3a03d47 Compare Apr 3, 2022
@kulti
Copy link
Contributor Author

@kulti kulti commented Apr 3, 2022

@ldez, that is not possible, because fuzzing tests are only in go 1.18. I've made a new release with old API support and wip commit to check.

@kulti
Copy link
Contributor Author

@kulti kulti commented Apr 3, 2022

I've seen that some linters disabled for go1.18. Maybe we can disable this linter for go1.18? Or use two versions — one will be disabled for >= go1.18, another for < go.1.18.

@ldez
Copy link
Member

@ldez ldez commented Apr 3, 2022

I've seen that some linters disabled for go1.18. Maybe we can disable this linter for go1.18? Or use two versions — one will be disabled for >= go1.18, another for < go.1.18.

We need to build with go1.17 in the CI, at least for now.

The linters are currently not handled by build tags, all linters can be built with go1.17.
They are just replaced/inactivated at runtime.

@ldez
Copy link
Member

@ldez ldez commented Apr 3, 2022

that is not possible, because fuzzing tests are only in go 1.18. I've made a new release with old API support and wip commit to check.

It's possible because you don't have go1.18 dependency except types.NewSignatureType

In your repo, you can play with build tags and split test files.

In golangci-lint we cannot do the same, we can just don't put tests for fuzz inside golangci-lint.

But your code must be go1.17 compatible.

@ldez
Copy link
Member

@ldez ldez commented Apr 3, 2022

Another solution is to release a v1 (go1.17) and v2 (go1.18) of your linter so that we will be able to use both versions.

The ZeroVer is not something great with go modules: go is able to manage 2 versions of a lib but a major version is required.
ZeroVer can be used for applications but for libraries it's a real problem.

In all cases, both versions will be a problem because the configuration will not be the same.

@kulti
Copy link
Contributor Author

@kulti kulti commented Apr 3, 2022

Ok. Thank you for your ideas. I'll think about them and try to fix build on the week.

@ldez ldez marked this pull request as draft Apr 3, 2022
@ldez
Copy link
Member

@ldez ldez commented Apr 3, 2022

I created a PR (#2744) to allow tests that use go1.18 in tests files.

The linters still need to build with go1.17.

@kulti kulti force-pushed the bump-thelper-v0.6.0 branch 2 times, most recently from faa3445 to 4385315 Compare Apr 6, 2022
@kulti kulti force-pushed the bump-thelper-v0.6.0 branch from 4385315 to 9a5b75d Compare Apr 6, 2022
@kulti kulti changed the title bump github.com/kulti/thelper from 0.5.1 to 0.6.0 bump github.com/kulti/thelper from 0.5.1 to 0.6.2 Apr 6, 2022
@kulti kulti marked this pull request as ready for review Apr 6, 2022
@ldez ldez removed the blocked label Apr 6, 2022
ldez
ldez approved these changes Apr 6, 2022
Copy link
Member

@ldez ldez left a comment

LGTM

@kulti kulti merged commit 7086a94 into golangci:master Apr 7, 2022
16 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
linter: update version
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants