Skip to content

gh-59757: Look in locale-bundle location for .mo #110806

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 2 commits into from

Conversation

nanjekyejoannah
Copy link
Contributor

@nanjekyejoannah nanjekyejoannah commented Oct 13, 2023

Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please fix tests, add specific tests, and update the documentation.

Also, it looks like languages processing is repeated, but we can discuss this after adding working tests.

Comment on lines +481 to +482
if localedir in [None, _default_localebundledir]:
bundle = find(domain, localedir=_default_localebundledir, languages=languages, all=all)
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should not there be an infinite recursion?

@bedevere-app
Copy link

bedevere-app bot commented Jan 24, 2024

When you're done making the requested changes, leave the comment: I have made the requested changes; please review again.

@encukou
Copy link
Member

encukou commented Feb 28, 2025

It's been a year, and it looks like this is no longer a problem on OpenSUSE (see the issue).

I'll close; please reopen if you have more info.

@encukou encukou closed this Feb 28, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants