GH-110819: fix maybe-uninitialized warnings on longobject.c #110821
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Filipe Laíns <lains@riseup.net>
jkloth
reviewed
Oct 13, 2023
| @@ -1935,6 +1935,7 @@ long_to_decimal_string_internal(PyObject *aa, | |||
| } while (0) | |||
|
|
|||
| /* fill the string right-to-left */ | |||
| assert (kind > 0); | |||
There was a problem hiding this comment.
This assert would seem to fail when just bytes_writer is passed into the function. It seems that this is the case where kind is uninitialized (the if-block at lines 1875-1896, particularly 1882-1887).
There was a problem hiding this comment.
We can fix that and land that PR first.
|
Closed in favor of GH-116599. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
maybe-uninitializedcompiler warnings onlong_format_binaryandlong_to_decimal_string_internal#110819