Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove unnecessary while in SocketIO.readinto #111057

Merged
merged 1 commit into from Oct 19, 2023

Conversation

sc07kvm
Copy link
Contributor

@sc07kvm sc07kvm commented Oct 19, 2023

These changes remove unnecessary while left over from the commit 6e6c59b:

while True:
    try:
        return self._sock.recv_into(b)
    except timeout:
        self._timeout_occurred = True
        raise
    except InterruptedError:  // <---------- removed
        continue              // <---------- removed
    except error as e:
        if e.args[0] in _blocking_errnos:
            return None
        raise

-->

while True:
    try:
        return self._sock.recv_into(b)
    except timeout:
        self._timeout_occurred = True
        raise
    except error as e:
        if e.args[0] in _blocking_errnos:
            return None
        raise

@cpython-cla-bot
Copy link

cpython-cla-bot bot commented Oct 19, 2023

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-app
Copy link

bedevere-app bot commented Oct 19, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@bedevere-app
Copy link

bedevere-app bot commented Oct 19, 2023

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@serhiy-storchaka serhiy-storchaka merged commit 677d4bc into python:main Oct 19, 2023
26 checks passed
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @sc07kvm.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants