Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-101726: Update the OpenSSL version to 1.1.1t #101727

Merged
merged 5 commits into from Feb 9, 2023
Merged

gh-101726: Update the OpenSSL version to 1.1.1t #101727

merged 5 commits into from Feb 9, 2023
+21 −17

Conversation

gpshead
Copy link
Member

@gpshead gpshead commented Feb 9, 2023 •
edited

Fixes CVE-2023-0286 (High) and a couple of Medium security issues.

https://www.openssl.org/news/secadv/20230207.txt

@gpshead gpshead requested review from a team as code owners February 9, 2023 05:59
@bedevere-bot bedevere-bot mentioned this pull request Feb 9, 2023
Closed
@gpshead gpshead added needs backport to 3.7 only security fixes needs backport to 3.8 only security fixes needs backport to 3.9 only security fixes needs backport to 3.10 only security fixes needs backport to 3.11 bug and security fixes labels Feb 9, 2023
ned-deily
ned-deily reviewed Feb 9, 2023
View reviewed changes
Copy link
Member

@ned-deily ned-deily left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The macOS installer change looks good, thanks.

@ambv
Copy link
Contributor

ambv commented Feb 9, 2023

For Windows we need 1.1.1t here first: https://github.com/python/cpython-source-deps/tree/openssl-1.1.1

@zooba
Copy link
Member

zooba commented Feb 9, 2023

I'm working on the build, but OpenSSL introduced an ARM64 regression and consider the platform "unadopted" and so won't rerelease to fix it: openssl/openssl#20234

I'll pull the patch into our own sources and retag them.

@zooba
Copy link
Member

zooba commented Feb 9, 2023

Binaries have been published, so I retriggered the builds

@zooba zooba merged commit b41c47c into python:main Feb 9, 2023
17 checks passed
@miss-islington
Copy link
Contributor

Thanks @gpshead for the PR, and @zooba for merging it 🌮🎉.. I'm working now to backport this PR to: 3.7, 3.8, 3.9, 3.10, 3.11.
🐍🍒⛏🤖

@miss-islington
Copy link
Contributor

Sorry, @gpshead and @zooba, I could not cleanly backport this to 3.11 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b41c47cd0606e8273aef4813e83fe2deaf9ab33b 3.11

@miss-islington
Copy link
Contributor

Sorry @gpshead and @zooba, I had trouble checking out the 3.10 backport branch.
Please retry by removing and re-adding the "needs backport to 3.10" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker b41c47cd0606e8273aef4813e83fe2deaf9ab33b 3.10

@miss-islington
Copy link
Contributor

Sorry, @gpshead and @zooba, I could not cleanly backport this to 3.9 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b41c47cd0606e8273aef4813e83fe2deaf9ab33b 3.9

@miss-islington
Copy link
Contributor

Sorry @gpshead and @zooba, I had trouble checking out the 3.8 backport branch.
Please retry by removing and re-adding the "needs backport to 3.8" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker b41c47cd0606e8273aef4813e83fe2deaf9ab33b 3.8

@miss-islington
Copy link
Contributor

Sorry, @gpshead and @zooba, I could not cleanly backport this to 3.7 due to a conflict.
Please backport using cherry_picker on command line.
cherry_picker b41c47cd0606e8273aef4813e83fe2deaf9ab33b 3.7

@bedevere-bot
Copy link

GH-101749 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 bug and security fixes label Feb 9, 2023
zooba pushed a commit to zooba/cpython that referenced this pull request Feb 9, 2023
@gpshead @zooba
pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727)
6eb7d45 
Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt
@bedevere-bot
Copy link

GH-101750 is a backport of this pull request to the 3.10 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.10 only security fixes label Feb 9, 2023
@bedevere-bot
Copy link

GH-101751 is a backport of this pull request to the 3.9 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.9 only security fixes label Feb 9, 2023
zooba pushed a commit to zooba/cpython that referenced this pull request Feb 9, 2023
@gpshead @zooba
pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727)
f42aca4 
Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt
@bedevere-bot
Copy link

GH-101752 is a backport of this pull request to the 3.8 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.8 only security fixes label Feb 9, 2023
zooba pushed a commit to zooba/cpython that referenced this pull request Feb 9, 2023
@gpshead @zooba
pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727)
e5bc753 
Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt
@bedevere-bot
Copy link

GH-101753 is a backport of this pull request to the 3.7 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.7 only security fixes label Feb 9, 2023
zooba added a commit that referenced this pull request Feb 9, 2023
@zooba @gpshead
gh-101726: Update the OpenSSL version to 1.1.1t (GH-101727)
b8149a9 
Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt

---------

Co-authored-by: Gregory P. Smith <greg@krypto.org>
zooba added a commit that referenced this pull request Feb 9, 2023
@zooba @gpshead
gh-101726: Update the OpenSSL version to 1.1.1t (GH-101727)
52a03a0 
Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt

Co-authored-by: Gregory P. Smith <greg@krypto.org>
ned-deily added a commit that referenced this pull request Feb 9, 2023
@zooba @gpshead @ned-deily
[3.7] gh-101726: Update the OpenSSL version to 1.1.1t (GH-101727) (GH…
cbd192b 
…-101753)

Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Ned Deily <nad@python.org>
carljm added a commit to carljm/cpython that referenced this pull request Feb 10, 2023
@carljm
Merge branch 'main' into inlinecomp2
add772e 
* main:
  Fix some typos in asdl_c.py (pythonGH-101757)
  pythongh-101747: Fix refleak in new `OrderedDict` repr (pythonGH-101748)
  pythongh-101430: Update tracemalloc to handle presize properly. (pythongh-101745)
  pythonGH-101228: Fix typo in docstring for read method of `_io.TextIOWrapper` class (python#101227)
  Fix typo in `test_fstring.py` (python#101600)
  pythongh-101726: Update the OpenSSL version to 1.1.1t (pythonGH-101727)
  pythongh-101283: Fix 'versionchanged' for the shell=True fallback on Windows in 3.12 (pythonGH-101728)
  LibFFI build requires x64 Cygwin, and skip the ARM build (pythonGH-101743)
ned-deily added a commit that referenced this pull request Mar 7, 2023
@zooba @gpshead @ned-deily
[3.9] gh-101726: Update the OpenSSL version to 1.1.1t (GH-101727) (GH…
bf99e19 
…-101751)

Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Ned Deily <nad@python.org>
ned-deily added a commit that referenced this pull request Mar 7, 2023
@zooba @gpshead @ned-deily
[3.8] gh-101726: Update the OpenSSL version to 1.1.1t (GH-101727) (GH…
ddd495e 
…-101752)

Fixes CVE-2023-0286 (High) and a couple of Medium security issues.
https://www.openssl.org/news/secadv/20230207.txt

Co-authored-by: Gregory P. Smith <greg@krypto.org>
Co-authored-by: Ned Deily <nad@python.org>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ned-deily ned-deily ned-deily left review comments

@python/windows-team windows-team

@ezio-melotti ezio-melotti

Assignees

@zooba zooba

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@gpshead @ambv @zooba @miss-islington @bedevere-bot @ned-deily