Skip to content

Fix typo in configparser module docstring #105652

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 11, 2023
Merged

Fix typo in configparser module docstring #105652

merged 1 commit into from
Jun 11, 2023

Conversation

litlighilit
Copy link
Contributor

See the following spell, which is zc.buildout.

And even if there is a package called buildbot, it seems to does nothing with "interpolation between sections" as well as the "zc." prefix

@litlighilit
Update configparser.py, correct zc.buildbot to zc.buildout in docstring
4291c8d 
See [the following spell](https://github.com/python/cpython/blob/main/Lib/configparser.py#L421), 
which is `zc.buildout`.

And even if there is a package called `buildbot`, it seems to does nothing with "interpolation between sections" as well as the "zc." prefix
@ghost
Copy link

ghost commented Jun 11, 2023 •
edited by ghost
Loading

All commit authors signed the Contributor License Agreement.
CLA signed

@bedevere-bot

This comment was marked as resolved.

Sign in to view
@litlighilit litlighilit changed the title gh-correct zc.buildbot to zc.buildout in docstring Fix docstring. correct zc.buildbot to zc.buildout in docstring Jun 11, 2023
AlexWaygood
AlexWaygood approved these changes Jun 11, 2023
View reviewed changes
Copy link
Member

@AlexWaygood AlexWaygood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, but you will need to sign the CLA, or we won't be able to merge

@AlexWaygood AlexWaygood self-assigned this Jun 11, 2023
@AlexWaygood AlexWaygood added needs backport to 3.11 only security fixes needs backport to 3.12 only security fixes labels Jun 11, 2023
@AlexWaygood AlexWaygood changed the title Fix docstring. correct zc.buildbot to zc.buildout in docstring Fix typo in configparser module docstring Jun 11, 2023
@litlighilit
Copy link
Contributor Author

@AlexWaygood

Glad for your reply,
but I have trouble entering that url.

Is there another way to show my agreement?

@AlexWaygood
Copy link
Member

@litlighilit you need to click the "CLA not signed" button in this comment here: #105652 (comment). I don't know of any other way to sign the CLA, I'm afraid.

but I have trouble entering that url.

What specifically is the problem you're running into? :)

@litlighilit

This comment was marked as off-topic.

Sign in to view
@litlighilit
Copy link
Contributor Author

@AlexWaygood
I have overcome that trouble and signed the CLA

@AlexWaygood AlexWaygood merged commit 845e593 into python:main Jun 11, 2023
@miss-islington
Copy link
Contributor

Thanks @litlighilit for the PR, and @AlexWaygood for merging it 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖

@bedevere-bot
Copy link

GH-105653 is a backport of this pull request to the 3.12 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@litlighilit @miss-islington
Fix typo in configparser module docstring (pythonGH-105652)
fdd3a7a 
"zc.buildbot" -> "zc.buildout"
(cherry picked from commit 845e593)

Co-authored-by: litlighilit <97860435+litlighilit@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 11, 2023
@bedevere-bot
Copy link

GH-105654 is a backport of this pull request to the 3.11 branch.

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
@litlighilit @miss-islington
Fix typo in configparser module docstring (pythonGH-105652)
c81d016 
"zc.buildbot" -> "zc.buildout"
(cherry picked from commit 845e593)

Co-authored-by: litlighilit <97860435+litlighilit@users.noreply.github.com>
@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 11, 2023
@AlexWaygood
Copy link
Member

Thanks @litlighilit!

@litlighilit
Copy link
Contributor Author

Grateful for your patience @AlexWaygood

AlexWaygood pushed a commit that referenced this pull request Jun 11, 2023
@miss-islington @litlighilit
[3.12] Fix typo in configparser module docstring (GH-105652) (#105653)
071d559 
Fix typo in configparser module docstring (GH-105652)

"zc.buildbot" -> "zc.buildout"
(cherry picked from commit 845e593)

Co-authored-by: litlighilit <97860435+litlighilit@users.noreply.github.com>
AlexWaygood pushed a commit that referenced this pull request Jun 11, 2023
@miss-islington @litlighilit
[3.11] Fix typo in configparser module docstring (GH-105652) (#105654)
2ba8e6a 
Fix typo in configparser module docstring (GH-105652)

"zc.buildbot" -> "zc.buildout"
(cherry picked from commit 845e593)

Co-authored-by: litlighilit <97860435+litlighilit@users.noreply.github.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@AlexWaygood AlexWaygood AlexWaygood approved these changes

Assignees

@AlexWaygood AlexWaygood

Labels
skip issue skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@litlighilit @bedevere-bot @AlexWaygood @miss-islington