[WebProfilerBundle] Fix intercept external redirects #52584
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| @@ -39,7 +39,7 @@ | |||
| <div class="block-exception"> | |||
| <h1>Redirection Intercepted</h1> | |||
|
|
|||
| {% set absolute_url = host in location ? location : host ~ location %} | |||
| {% set absolute_url = host in location or not (location starts with '/') ? location : host ~ location %} | |||
There was a problem hiding this comment.
//protocol-relative URLs are a thing :) Also, . is a hint of a relative URL.
|
Maybe we could do this computation in the Controller directly ? Currently the code look like this (just formatted for clarity) WebProfilerBundle/EventListener/WebDebugToolbarListener.php $content = $this->twig->render('@WebProfiler/Profiler/toolbar_redirect.html.twig', [
'location' => $response->headers->get('Location'),
'host' => $request->getSchemeAndHttpHost()
]);
$response->setContent($content);
$response->setStatusCode(200);
$response->headers->remove('Location');Something like this could do the job WDYT ? $content = $this->twig->render('@WebProfiler/Profiler/toolbar_redirect.html.twig', [
'location' => $location = $response->headers->get('Location'),
'absolute_location' => (new UrlHelper($requestStack))->getAbsoluteUrl($location),
]);
$response->setContent($content);
$response->setStatusCode(200);
$response->headers->remove('Location');And that'd allow to keep in one place all those 'Location' manipulation / transformations. Because, even with the best intentions, i'm not sure the template code would be ever "obvious" (e g : WDYT ? |
|
I agree with @smnandre's proposal, the template can't contain this logic. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When intercepting a redirect to an external host the current output gives:
With this PR, it fixes it too:
We could eventually get rid of the first part of the condition, WDYT?