[Console] Add assertCommandIsFaulty assertion
#52479
Conversation
|
Hey! I see that this is your first PR. That is great! Welcome! Symfony has a contribution guide which I suggest you to read. In short:
Review the GitHub status checks of your pull request and try to solve the reported issues. If some tests are failing, try to see if they are failing because of this change. When two Symfony core team members approve this change, it will be merged and you will become an official Symfony contributor! I am going to sit back now and wait for the reviews. Cheers! Carsonbot |
src/Symfony/Component/Console/Tester/Constraint/CommandIsFaulty.php
Outdated
Show resolved
Hide resolved
OskarStark
changed the title
assertCommandIsFaulty assertion
src/Symfony/Component/Console/Tester/Constraint/CommandIsFaulty.php
Outdated
Show resolved
Hide resolved
src/Symfony/Component/Console/Tests/Tester/Constraint/CommandIsFaultyTest.php
Outdated
Show resolved
Hide resolved
|
Should I rebase? |
|
rebased, squashed ✅ |
|
|
||
| try { | ||
| $constraint->evaluate(Command::SUCCESS); | ||
| } catch (ExpectationFailedException $e) { |
There was a problem hiding this comment.
What about using expectException() instead?
| { | ||
| return Command::SUCCESS === $other | ||
| ? 'Command was successful.' | ||
| : sprintf('Command returned exit status %d.', $other); |
|
|
||
| try { | ||
| $constraint->evaluate(Command::SUCCESS); | ||
| } catch (ExpectationFailedException $e) { |
|
Closing as there is no more activity and adding another method is maybe not a good idea. |
Adds the complement of the
assertCommandIsSuccessfulassertion and improves thereby test readability.