refactor(core): Invert the application<->scheduler dependency #52977
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
atscott
added
the
action: global presubmit
atscott
force-pushed
the
invertSchedulerDependency
branch
3 times, most recently
from
afd1832 to
2fd5264
Compare
JoostK
reviewed
Nov 16, 2023
atscott
force-pushed
the
invertSchedulerDependency
branch
from
2fd5264 to
39c8cf5
Compare
JeanMeche
reviewed
Nov 16, 2023
atscott
force-pushed
the
invertSchedulerDependency
branch
from
39c8cf5 to
fb71ddc
Compare
This commit inverts the dependency between the application and the scheduler. The application depends on the scheduling mechanism to trigger view refreshes rather than the other way around. This allows us to share the scheduling flush notification between `ComponentFixture` code and `ApplicationRef`.
atscott
force-pushed
the
invertSchedulerDependency
branch
from
fb71ddc to
4afed15
Compare
|
This issue has been automatically locked due to inactivity. Read more about our automatic conversation locking policy. This action has been performed automatically by a bot. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This commit inverts the dependency between the application and the scheduler. The application depends on the scheduling mechanism to trigger view refreshes rather than the other way around. This allows us to share the scheduling flush notification between
ComponentFixturecode andApplicationRef.