Skip to content

Fix Tractive switch availability #104502

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Nov 28, 2023
Merged

Fix Tractive switch availability #104502

merged 5 commits into from
Nov 28, 2023

Conversation

bieniu
Copy link
Member

@bieniu bieniu commented Nov 25, 2023 •
edited
Loading

Breaking change

Proposed change

After analyzing logs from users, it turned out that events related to switches often contain only part of the data, e.g. data regarding only one switch. Which caused switch entities to be marked as unavailable.

Currently, switch state will be sent by the dispatcher with a separate signal and the availability of the switch entity will not depend on the presence of complete data in the event, but only on whether the Tractive API is online/offline.

Now the switch entities have been available all the time for the last 24 hours.

obraz

Type of change

  • Dependency upgrade
  • Bugfix (non-breaking change which fixes an issue)
  • New integration (thank you!)
  • New feature (which adds functionality to an existing integration)
  • Deprecation (breaking change to happen in the future)
  • Breaking change (fix/feature causing existing functionality to break)
  • Code quality improvements to existing code or addition of tests

Additional information

Checklist

  • The code change is tested and works locally.
  • Local tests pass. Your PR cannot be merged unless tests pass
  • There is no commented out code in this PR.
  • I have followed the development checklist
  • I have followed the perfect PR recommendations
  • The code has been formatted using Black (black --fast homeassistant tests)
  • Tests have been added to verify that the new code works.

If user exposed functionality or configuration variables are added/changed:

If the code communicates with devices, web services, or third-party tools:

  • The manifest file has all fields filled out correctly.
    Updated and included derived files by running: python3 -m script.hassfest.
  • New or updated dependencies have been added to requirements_all.txt.
    Updated by running python3 -m script.gen_requirements_all.
  • For the updated dependencies - a link to the changelog, or at minimum a diff between library versions is added to the PR description.
  • Untested files have been added to .coveragerc.

To help with the load of incoming pull requests:

@home-assistant
Copy link

Hey there @Danielhiversen, @zhulik, mind taking a look at this pull request as it has been labeled with an integration (tractive) you are listed as a code owner for? Thanks!

Code owner commands

Code owners of tractive can trigger bot actions by commenting:

  • @home-assistant close Closes the pull request.
  • @home-assistant rename Awesome new title Renames the pull request.
  • @home-assistant reopen Reopen the pull request.
  • @home-assistant unassign tractive Removes the current integration label and assignees on the pull request, add the integration domain after the command.
  • @home-assistant add-label needs-more-information Add a label (needs-more-information, problem in dependency, problem in custom component) to the pull request.
  • @home-assistant remove-label needs-more-information Remove a label (needs-more-information, problem in dependency, problem in custom component) on the pull request.

@bieniu bieniu marked this pull request as ready for review November 27, 2023 15:44
@frenck frenck added the smash Indicator this PR is close to finish for merging or closing label Nov 27, 2023
edenhaus
edenhaus approved these changes Nov 28, 2023
View reviewed changes
Copy link
Member

@edenhaus edenhaus left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks @bieniu 👍

@edenhaus
Copy link
Member

@bieniu Do you still want to have a review from @Danielhiversen or can we merge it?

@bieniu
Copy link
Member Author

bieniu commented Nov 28, 2023

It seems that Daniel has not been very active lately and we may have to wait a long time for his review.
IMO we can merge the change to be included in the beta.

@edenhaus edenhaus merged commit 2d2e215 into home-assistant:dev Nov 28, 2023
@bieniu bieniu deleted the tractive-switch-availability branch November 28, 2023 11:48
@github-actions github-actions bot locked and limited conversation to collaborators Nov 29, 2023
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@edenhaus edenhaus edenhaus approved these changes

@Danielhiversen Danielhiversen Awaiting requested review from Danielhiversen Danielhiversen is a code owner

Assignees

@Danielhiversen Danielhiversen

Labels
bugfix by-code-owner cla-signed integration: tractive Quality Scale: No score smash Indicator this PR is close to finish for merging or closing
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Tractive: Live tracking unavailable
4 participants
@bieniu @edenhaus @frenck @Danielhiversen