Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Cache] \Redis::mget() can return bool, Redis6Proxy::mget() doesn't account for that #52668

Open
dkarlovi opened this issue Nov 21, 2023 · 1 comment
Open

[Cache] \Redis::mget() can return bool, Redis6Proxy::mget() doesn't account for that #52668

dkarlovi opened this issue Nov 21, 2023 · 1 comment
Labels
Bug Cache Status: Needs Review

Comments

@dkarlovi
Copy link
Contributor

Symfony version(s) affected

6.3.5

Description

Redis::mget can return false when no keys are provided. phpredis/phpredis#1810

This is annoying because the signature says mget(): \Redis|array, but it's actually mget(): \Redis|array|false.

Redis6Proxy::mget has the correct signature, but it doesn't handle the possible false.

How to reproduce

Set up PHPRedis v6 and do Redis6Proxy::mget([])

Possible Solution

Return [] if false.

Additional Context

IMO this is a bug in the module, but it's a bug since 2020.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
Bug Cache Status: Needs Review
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@dkarlovi @alexandre-daubois @carsonbot