Upgrade bootswatch to version 4 #1183
Conversation
{% block form_errors -%} | ||
{% if errors|length > 0 -%} | ||
{% if form is not rootform %}<span class="help-block">{% else %}<div class="alert alert-danger">{% endif %} | ||
<ul class="list-unstyled"> | ||
{%- for error in errors -%} | ||
{# use font-awesome icon library #} | ||
{# use font-awesome icon library # } |
bechir
Dec 30, 2020
Author
And the test testAdminNewDuplicatedPost
method is failing because we no longer have form-group.has-error
noniagriconomie
Dec 30, 2020
Contributor
i was commenting to rollback the extra space on the precise line i commented on
from
{# use font-awesome icon library #}
to
{# use font-awesome icon library # }
sorry if it was unclear :s
bechir
Dec 30, 2020
Author
Ah sorry.
The reason why I added that extra space is when I don't do so the code after that line will not be commented
@@ -3,6 +3,9 @@ | |||
common elements and decorates all the other templates. | |||
See https://symfony.com/doc/current/templates.html#template-inheritance-and-layouts | |||
#} | |||
|
|||
{% set route = app.request.get('_route') %} |
noniagriconomie
Dec 29, 2020
Contributor
{% set route = app.request.get('_route') %} | |
{% set _route = app.request.get('_route') %} |
what about this?
nice one :) |
Hi @noniagriconomie, I updated my code but the datetime picker initialization is still missing. |
@bechir i think i am not the person who will decide if or not to replace this lib, |
OK thanks you again. |
Hi,
After comparing changes before and after in #1030 I said to myself It's maybe better to create remake the job with new newly updated
Symfony 5.2
(andbootswtach v5.4.3
).I know @javiereguiluz wanted to resolve the conflicts himself but you can still see the work I did here
Comparaison home
Before
After
Comparaison blog
Before
After
Comparaison show code
Before
After
Comparaison pagination
Before
After
Comparaison login
Before
After
Comparaison admin
Before
After
Comparaison edit post
Before
After
Comparaison show post
Before
After
Comparaison edit post (tags)
Before
After
Comparaison post with errors
Before
After
CHANGELOG
In packages.json
eonasdan-bootstrap-datetimepicker
dependency (This is not compatible with bootstrap 4)In scss files
$icon-font-path
we no longer need this_variables.scss
file containg our custom variablesIn javascript files
submit()
bytrigger('submit')
In twig files
well
class byjumbotron
with some changes in the default paddingslabel label-*
bybadge badge-*
pull-right
byfloat-right
I d'ont kown if it's the same but we have the same resultactive
Tests
App\Tests\Controller\Admin\BlogControllerTest::testAdminNewPost
I didn't added
datetimepicker
yet because the tempusdominus/bootstrap-4 project is getting rolled back into the orginal repo, but it's still in progress.This lib is for bootstrap 4 and it's based on the Eonasdan's Bootstrap 3 date/time picker.
But flatpickr is more powerful with zero dependencies
I didn't added it yet, I'm juste waiting for feedbacks.
Thanks for your time!