Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Form] Clean unused code #52660

Merged
merged 1 commit into from Nov 23, 2023
Merged

Conversation

alamirault
Copy link
Contributor

@alamirault alamirault commented Nov 20, 2023

Q A
Branch? 7.1
Bug fix? no
New feature? no
Deprecations? no
Issues Fix #...
License MIT

Remove unused code

@carsonbot
Copy link

Hey!

Thanks for your PR. You are targeting branch "7.1" but it seems your PR description refers to branch "7.1 for features / 5.4, 6.3, 6.4, or 7.0 for bug fixes".
Could you update the PR description or change target branch? This helps core maintainers a lot.

Cheers!

Carsonbot

@carsonbot carsonbot added this to the 7.1 milestone Nov 20, 2023
@alamirault alamirault force-pushed the feature/clean-unused-code-3 branch 2 times, most recently from f50bc32 to d6ab282 Compare November 20, 2023 18:50
@fabpot
Copy link
Member

fabpot commented Nov 23, 2023

Thank you @alamirault.

@fabpot fabpot merged commit 8e0f304 into symfony:7.1 Nov 23, 2023
3 of 9 checks passed
@alamirault alamirault deleted the feature/clean-unused-code-3 branch November 23, 2023 16:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants