Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add pooling support for 3d channels last #116305

Closed
wants to merge 1 commit into from

Conversation

dmenig
Copy link
Collaborator

@dmenig dmenig commented Dec 21, 2023

Part of a multi-PR work to improve #59168

Meant to complete
Write native kernels for AvgPool3d
Write native kernels for MaxPool3d
Write native kernels for AdaptiveAvgPool3d
Write native kernels for AdaptiveMaxPool3d

cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @albanD

Copy link

pytorch-bot bot commented Dec 21, 2023

🔗 Helpful Links

🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116305

Note: Links to docs will display an error until the docs builds have been completed.

✅ No Failures

As of commit d8017ae with merge base 946e202 (image):
💚 Looks good so far! There are no failures yet. 💚

This comment was automatically generated by Dr. CI and updates every 15 minutes.

@github-actions github-actions bot added the module: cpu CPU specific problem (e.g., perf, algorithm) label Dec 21, 2023
Copy link

This PR needs a release notes: label

If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

@dmenig dmenig force-pushed the 3d_channels_last_pooling_3 branch 3 times, most recently from e66c883 to 6f2e75a Compare December 22, 2023 16:16
@dmenig dmenig closed this Jan 9, 2024
@dmenig dmenig reopened this Jan 9, 2024
@dmenig dmenig force-pushed the 3d_channels_last_pooling_3 branch 3 times, most recently from 6ef2e60 to dbd2fab Compare January 12, 2024 09:49
@dmenig dmenig changed the title WIP Add pooling support for 3d channels last Add pooling support for 3d channels last Jan 15, 2024
@dmenig
Copy link
Collaborator Author

dmenig commented Jan 15, 2024

I think I need approval to keep debugging with the CI please

@ezyang
Copy link
Contributor

ezyang commented Jan 16, 2024

I added you to the repo, that should durably give you rights

@ezyang ezyang requested a review from mingfeima January 16, 2024 20:26
@ezyang ezyang added the triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module label Jan 16, 2024
@dmenig
Copy link
Collaborator Author

dmenig commented Jan 17, 2024

Thx, this is my current error in the CI, I don't get it. Can anyone provide some insight please ?

distributed/test_store 1/1 failed! Received signal: SIGIOT
Emiting td_test_failure_stats
could not find path /var/lib/jenkins/workspace/.additional_ci_files/previous_failures.json
Traceback (most recent call last):
  File "/var/lib/jenkins/workspace/test/run_test.py", line 1812, in <module>
    main()
  File "/var/lib/jenkins/workspace/test/run_test.py", line 1764, in main
    run_tests(
  File "/var/lib/jenkins/workspace/test/run_test.py", line 1620, in run_tests
    raise RuntimeError(failure.message)
RuntimeError: distributed/test_store 1/1 failed! Received signal: SIGIOT

I launched the CI again in case it's a dud.

@ezyang
Copy link
Contributor

ezyang commented Jan 18, 2024

It might just be flaky master, check what dr ci says (i can't see it anymore since you repushed)

@dmenig
Copy link
Collaborator Author

dmenig commented Jan 19, 2024

This now passes. Please review :)

@ezyang
Copy link
Contributor

ezyang commented Jan 21, 2024

@mingfeima will you be reviewing this?

@ppwwyyxx
Copy link
Contributor

btw, don't say fix #59168 in the PR description if you don't intend to let the PR close the issue

Copy link

Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as Stale.
Feel free to remove the Stale label if you feel this was a mistake.
If you are unable to remove the Stale label please contact a maintainer in order to do so.
If you want the bot to never mark this PR stale again, add the no-stale label.
Stale pull requests will automatically be closed after 30 days of inactivity.

@github-actions github-actions bot added the Stale label Mar 30, 2024
@dmenig
Copy link
Collaborator Author

dmenig commented Apr 17, 2024

I still think this is relevant.

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@dmenig
Copy link
Collaborator Author

dmenig commented Apr 29, 2024

I guess those are user facing, no ? @ezyang

@dmenig
Copy link
Collaborator Author

dmenig commented Apr 29, 2024

They would maybe need a comment saying something like : "3D pooling is now compatible with channels last tensors".

@dmenig dmenig requested a review from ezyang April 29, 2024 14:40
@ezyang ezyang added topic: new features topic category module: python frontend For issues relating to PyTorch's Python frontend labels Apr 29, 2024
@ezyang
Copy link
Contributor

ezyang commented Apr 29, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: This PR needs a release notes: label
If your changes are user facing and intended to be a part of release notes, please use a label starting with release notes:.

If not, please add the topic: not user facing label.

To add a label, you can comment to pytorchbot, for example
@pytorchbot label "topic: not user facing"

For more information, see
https://github.com/pytorch/pytorch/wiki/PyTorch-AutoLabel-Bot#why-categorize-for-release-notes-and-how-does-it-work.

Details for Dev Infra team Raised by workflow job

@ezyang ezyang added the release notes: python_frontend release notes category label Apr 29, 2024
@ezyang
Copy link
Contributor

ezyang commented Apr 29, 2024

@pytorchbot merge

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

@pytorchmergebot
Copy link
Collaborator

Merge failed

Reason: 2 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral), trunk / linux-focal-rocm5.7-py3.8 / test (default, 1, 1, linux.rocm.gpu)

Details for Dev Infra team Raised by workflow job

@ezyang
Copy link
Contributor

ezyang commented Apr 30, 2024

@pytorchbot merge -r

@pytorchmergebot
Copy link
Collaborator

@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here

@pytorchmergebot
Copy link
Collaborator

Successfully rebased 3d_channels_last_pooling_3 onto refs/remotes/origin/viable/strict, please pull locally before adding more changes (for example, via git checkout 3d_channels_last_pooling_3 && git pull --rebase)

@pytorchmergebot
Copy link
Collaborator

Merge started

Your change will be merged once all checks pass (ETA 0-4 Hours).

Learn more about merging in the wiki.

Questions? Feedback? Please reach out to the PyTorch DevX Team

Advanced Debugging
Check the merge workflow status
here

pytorch-bot bot pushed a commit that referenced this pull request May 3, 2024
Part of a multi-PR work to improve #59168

Meant to complete
Write native kernels for AvgPool3d
Write native kernels for MaxPool3d
Write native kernels for AdaptiveAvgPool3d
Write native kernels for AdaptiveMaxPool3d

Pull Request resolved: #116305
Approved by: https://github.com/ezyang
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
ciflow/trunk Trigger trunk jobs on your pull request Merged module: cpu CPU specific problem (e.g., perf, algorithm) module: python frontend For issues relating to PyTorch's Python frontend open source release notes: python_frontend release notes category topic: new features topic category triaged This issue has been looked at a team member, and triaged and prioritized into an appropriate module
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants