-
Notifications
You must be signed in to change notification settings - Fork 21.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add pooling support for 3d channels last #116305
Conversation
🔗 Helpful Links🧪 See artifacts and rendered test results at hud.pytorch.org/pr/116305
Note: Links to docs will display an error until the docs builds have been completed. ✅ No FailuresAs of commit d8017ae with merge base 946e202 ( This comment was automatically generated by Dr. CI and updates every 15 minutes. |
This PR needs a
|
e66c883
to
6f2e75a
Compare
6f2e75a
to
05fb52f
Compare
05fb52f
to
0b9146b
Compare
6ef2e60
to
dbd2fab
Compare
I think I need approval to keep debugging with the CI please |
I added you to the repo, that should durably give you rights |
Thx, this is my current error in the CI, I don't get it. Can anyone provide some insight please ?
I launched the CI again in case it's a dud. |
dbd2fab
to
8e0c2a5
Compare
It might just be flaky master, check what dr ci says (i can't see it anymore since you repushed) |
This now passes. Please review :) |
@mingfeima will you be reviewing this? |
btw, don't say |
Looks like this PR hasn't been updated in a while so we're going to go ahead and mark this as |
I still think this is relevant. |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
I guess those are user facing, no ? @ezyang |
They would maybe need a comment saying something like : "3D pooling is now compatible with channels last tensors". |
@pytorchbot merge |
Merge failedReason: This PR needs a If not, please add the To add a label, you can comment to pytorchbot, for example For more information, see Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge |
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Merge failedReason: 2 jobs have failed, first few of them are: trunk / win-vs2019-cpu-py3 / test (default, 2, 3, windows.4xlarge.nonephemeral), trunk / linux-focal-rocm5.7-py3.8 / test (default, 1, 1, linux.rocm.gpu) Details for Dev Infra teamRaised by workflow job |
@pytorchbot merge -r |
@pytorchbot started a rebase job onto refs/remotes/origin/viable/strict. Check the current status here |
Successfully rebased |
8e0c2a5
to
d8017ae
Compare
Merge startedYour change will be merged once all checks pass (ETA 0-4 Hours). Learn more about merging in the wiki. Questions? Feedback? Please reach out to the PyTorch DevX Team |
Part of a multi-PR work to improve #59168 Meant to complete Write native kernels for AvgPool3d Write native kernels for MaxPool3d Write native kernels for AdaptiveAvgPool3d Write native kernels for AdaptiveMaxPool3d Pull Request resolved: #116305 Approved by: https://github.com/ezyang
Part of a multi-PR work to improve #59168
Meant to complete
Write native kernels for AvgPool3d
Write native kernels for MaxPool3d
Write native kernels for AdaptiveAvgPool3d
Write native kernels for AdaptiveMaxPool3d
cc @jgong5 @mingfeima @XiaobingSuper @sanchitintel @ashokei @jingxu10 @albanD