New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Frozen modules shouldn't be written to the source tree on Windows #113258
Comments
for future reference, the frozen modules Windows build is in |
@zooba I made an attempt in gh-113303 |
Make sure you've got the latest from main, and then look for There's also a script to update the project files with the properties you've edited, so make sure you find and update that first and then regenerate the files. It's probably in |
This ensures the source directory is not modified at build time, and different builds (e.g. different versions or GIL vs no-GIL) do not have conflicts.
Feature or enhancement
Proposal:
As a follow-up to gh-113039, this issue suggests we change the Windows build to avoid writing the generated frozen modules back into the source tree.
Quoting @zooba
This is already the case on Linux and MacOS, so making Windows use
$(IntDir)
for these is also more consistent.While we're there, consider also changing
getpath.c
again to includegetpath.h
, as suggested here.Has this already been discussed elsewhere?
This is a minor feature, which does not need previous discussion elsewhere
Links to previous discussion of this feature:
Previous discussion: gh-113039
Linked PRs
The text was updated successfully, but these errors were encountered: