Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-113258: Write frozen modules to the build tree on Windows #113303

Merged
merged 8 commits into from Jan 3, 2024
Merged

gh-113258: Write frozen modules to the build tree on Windows #113303

merged 8 commits into from Jan 3, 2024

Conversation

itamaro
Copy link
Contributor

@itamaro itamaro commented Dec 20, 2023 •
edited

Move generated frozen modules out of the source tree and into the build tree on Windows build

@bedevere-app bedevere-app bot mentioned this pull request Dec 20, 2023
Closed
@itamaro itamaro changed the title gh-113258: Write frozen modules to IntDir gh-113258: Write frozen modules to the build tree on Windows Dec 22, 2023
@itamaro itamaro requested a review from zooba December 22, 2023 00:02
@itamaro itamaro added OS-windows build The build process and cross-build labels Dec 22, 2023
@itamaro
Copy link
Contributor Author

itamaro commented Dec 22, 2023 •
edited

@zooba this seems to be working now (except for the seemingly unrelated pythoninfo failure) . please take a look. I can incorporate further feedback in a polish pass (adding NEWS and whatnot, assuming this is NEWS-worthy)

@itamaro itamaro marked this pull request as ready for review December 22, 2023 00:04
@itamaro itamaro requested a review from a team as a code owner December 22, 2023 00:04
zooba
zooba reviewed Dec 22, 2023
View reviewed changes
Copy link
Member

@zooba zooba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good, and seems to not affect POSIX builds, which is good.

I think we should have a NEWS item, but put it in the Build section (not Windows) and just specify that it changed the Windows build.

PCbuild/pyproject.props Outdated Show resolved Hide resolved
@zooba zooba merged commit 178919c into python:main Jan 3, 2024
29 checks passed
@zooba
Copy link
Member

zooba commented Jan 3, 2024

Thanks for all the work on this!

@itamaro itamaro deleted the gh-113258-windows-frozen-intdir branch January 3, 2024 18:32
@zooba zooba mentioned this pull request Jan 8, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@zooba zooba zooba left review comments

Assignees
No one assigned
Labels
build The build process and cross-build OS-windows
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@itamaro @zooba