Skip to content

[3.11] gh-101778: Fix build error when there's a dangling symlink in the directory containing "ffi.h" #113466

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Dec 26, 2023
Merged

[3.11] gh-101778: Fix build error when there's a dangling symlink in the directory containing "ffi.h" #113466

merged 1 commit into from
Dec 26, 2023

Conversation

ronaldoussoren
Copy link
Contributor

@ronaldoussoren ronaldoussoren commented Dec 25, 2023 •
edited by bedevere-app bot
Loading

grep_headers_for in setup.py was not robust when encountering dangling symlinks.

This PR directly targets 3.11 because the build machinery for extensions was changed in 3.12 and therefore main and 3.12 don't need updating.

@bedevere-app bedevere-app bot mentioned this pull request Dec 25, 2023
Closed
@ronaldoussoren ronaldoussoren changed the title gh-101778: Fix build error when there's a dangling symlink in the directory containing "ffi.h" [3.11] gh-101778: Fix build error when there's a dangling symlink in the directory containing "ffi.h" Dec 25, 2023
@ronaldoussoren ronaldoussoren merged commit 0eea5c0 into python:3.11 Dec 26, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ronaldoussoren @serhiy-storchaka