Add codeowners for Lib/ensurepip/
#112805
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Works for me! Thanks for doing this. |
pfmoore
approved these changes
Dec 6, 2023
ezio-melotti
approved these changes
Dec 6, 2023
schribl
approved these changes
Dec 8, 2023
pradyunsg
approved these changes
Dec 9, 2023
FWIW, this concern was somewhat unnecessary. 😅 We've got CI checks to ensure that the bundled copy of pip matches the one on PyPI: #112721 (comment) |
|
👋 friendly ping @dstufft -- are you okay with being added as a codeowner? I'm happy to remove you from this PR if not :) |
AlexWaygood
commented
Dec 24, 2023
|
Donald hasn't responded regarding whether or not he's okay with being added as a codeowner, so I've removed his username for now. It can always be added later :) |
ryan-duve
pushed a commit
to ryan-duve/cpython
that referenced
this pull request
Dec 26, 2023
kulikjak
pushed a commit
to kulikjak/cpython
that referenced
this pull request
Jan 22, 2024
aisk
pushed a commit
to aisk/cpython
that referenced
this pull request
Feb 11, 2024
Glyphack
pushed a commit
to Glyphack/cpython
that referenced
this pull request
Sep 2, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was some recent concern on the core dev Discord server about PRs from third-party contributors attempting to update the bundled version of pip. While sometimes it might be okay to accept these PRs, it's good for the pip maintainers to be kept in the loop whenever a PR like that is made from a third-party contributor. As such, this PR adds as
ensurepipcodeowners the three pip maintainers who are also core devs: @pradyunsg, @pfmoore and @dstufft. This means that all three will be automatically pinged for review whenever anybody creates a PR that touches files in theLib/ensurepip/directory.@pradyunsg, @pfmoore, @dstufft: please confirm you're okay with being added as codeowners! I'll obviously remove anybody who doesn't want to be added here :)