gh-113081: Print colorized exception just like built-in traceback in pdb #113082
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Open
|
@pablogsal could you share some thoughts on this? Do you think we need extra tests for pdb? Thanks! |
brandtbucher
reviewed
May 4, 2024
|
@pablogsal, any thoughts on this simple (colorful!) change? Otherwise I'm inclined to merge. :) |
Co-authored-by: Brandt Bucher <brandtbucher@gmail.com>
brandtbucher
approved these changes
May 4, 2024
|
What is the current proper way to disable color in tests? I thought there was a global mechanism implemented. I can do it for pdb only but want to make sure this is not something that should be covered already. |
|
Check out |
|
Looks like |
|
Okay seems like the tests passed now. My local tests worked fine and I did not have the time to figure out the difference. |
pablogsal
approved these changes
May 4, 2024
|
Let's merge it! |
SonicField
pushed a commit
to SonicField/cpython
that referenced
this pull request
May 8, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is the first step to colorize pdb - just use the existing colorized traceback for exceptions in post mortem mode. The code change is really trivial and it just calls the colorized version of exception printing in traceback.
Yes, it's using an internal function, but
pdbis stdlib so it can adapt when the function is changed. We can also useprint_exceptionbut we needtraceback._can_colorize()anyway - which should be put into a separate module if we want to colorize more modules.