Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update copyright years to 2024. #113608

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

Update copyright years to 2024. #113608

wants to merge 2 commits into from

Conversation

0xSalikh
Copy link

@0xSalikh 0xSalikh commented Jan 1, 2024 •
edited by github-actions bot

@0xSalikh 0xSalikh requested review from a team and vsajip as code owners January 1, 2024 01:20
@cpython-cla-bot CPython CLA Bot
Copy link

cpython-cla-bot bot commented Jan 1, 2024 •
edited

The following commit authors need to sign the Contributor License Agreement:

Click the button to sign:
CLA not signed

@bedevere-app
Copy link

bedevere-app bot commented Jan 1, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

@Eclips4 Eclips4 requested review from benjaminp and removed request for a team and vsajip January 1, 2024 08:08
benjaminp
benjaminp requested changes Jan 4, 2024
View reviewed changes
Copy link
Contributor

@benjaminp benjaminp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please only touch files similar to previous iterations of this change (like 11f9932). We shouldn't be modifying the license headers of files from third party sources.

Include/internal/mimalloc/mimalloc.h Outdated
@@ -1,5 +1,5 @@
/* ----------------------------------------------------------------------------
Copyright (c) 2018-2023, Microsoft Research, Daan Leijen
Copyright (c) 2018-2024, Microsoft Research, Daan Leijen
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

These minmalloc files should not be touched.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Corrected. Thank you for your comment)

@bedevere-app
Copy link

bedevere-app bot commented Jan 4, 2024

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

And if you don't make the requested changes, you will be put in the comfy chair!

@bedevere-app
Copy link

bedevere-app bot commented Jan 5, 2024

Most changes to Python require a NEWS entry. Add one using the blurb_it web app or the blurb command-line tool.

If this change has little impact on Python users, wait for a maintainer to apply the skip news label instead.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@benjaminp benjaminp benjaminp requested changes

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@0xSalikh @benjaminp