Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-32604: Disable failing tests #20777

Merged
merged 1 commit into from Jun 21, 2020
Merged

bpo-32604: Disable failing tests #20777

merged 1 commit into from Jun 21, 2020

Conversation

nanjekyejoannah
Copy link
Member

@nanjekyejoannah nanjekyejoannah commented Jun 10, 2020 •
edited by bedevere-bot

I decided to skip the tests in question until I get time to fix the races.

Requesting a second eye @pablogsal and @vstinner if this makes the bots green.

https://bugs.python.org/issue32604

@bedevere-bot bedevere-bot added tests Tests in the Lib/test dir awaiting core review labels Jun 10, 2020
ericsnowcurrently
ericsnowcurrently approved these changes Jun 17, 2020
View changes
Copy link
Member

@ericsnowcurrently ericsnowcurrently left a comment

LGTM

I'll see if we can track down the problem by the end of the week and get those tests re-enabled.

@vstinner
Copy link
Member

vstinner commented Jun 17, 2020 •
edited by bedevere-bot

The PR title is very misleading: "bpo-32604: PEP 554 implementation: add interpreters module #20777".

@nanjekyejoannah nanjekyejoannah changed the title bpo-32604: PEP 554 implementation: add interpreters module bpo-32604: Disable failing tests Jun 17, 2020
@nanjekyejoannah nanjekyejoannah merged commit 6f79838 into python:master Jun 21, 2020
4 checks passed
@nanjekyejoannah
Copy link
Member Author

nanjekyejoannah commented Jun 22, 2020

Merging until we get a fix @ericsnowcurrently

fasih pushed a commit to fasih/cpython that referenced this pull request Jun 29, 2020
@nanjekyejoannah @fasihahmad
Skip tests to fix bot (pythonGH-20777)
69b3080 
Co-authored-by: nanjekyejoannah <joannah.nanjekye@ibm.com>
arun-mani-j pushed a commit to arun-mani-j/cpython that referenced this pull request Jul 21, 2020
@nanjekyejoannah @arun-mani-j
Skip tests to fix bot (pythonGH-20777)
0d1d079 
Co-authored-by: nanjekyejoannah <joannah.nanjekye@ibm.com>
@ericsnowcurrently ericsnowcurrently mentioned this pull request Apr 10, 2022
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ericsnowcurrently ericsnowcurrently

@vstinner vstinner

@pablogsal pablogsal

Assignees
No one assigned
Labels
skip news tests Tests in the Lib/test dir
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@nanjekyejoannah @vstinner @ericsnowcurrently @the-knights-who-say-ni @bedevere-bot