Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-112498 Add heapremove and heapfix #112550

Open
wants to merge 15 commits into
base: main
Choose a base branch
from
Open

GH-112498 Add heapremove and heapfix #112550

wants to merge 15 commits into from
+275 ∄1�716

Conversation

kristjanvalur
Copy link
Contributor

@kristjanvalur kristjanvalur commented Nov 30, 2023 •
edited

This is an alternative PR to #112497 which adds two functions, heapfix and heapremove.
This is perhaps better, since the use cases are different. heappop becomes a special case of heapremove and

It corresponds to what golang does in https://pkg.go.dev/container/heap

📚 Documentation preview 📚: https://cpython-previews--112550.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request Nov 29, 2023
Open
@kristjanvalur kristjanvalur marked this pull request as ready for review November 30, 2023 12:03
@rhettinger rhettinger self-assigned this Dec 1, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@rhettinger rhettinger Awaiting requested review from rhettinger rhettinger is a code owner

Assignees

@rhettinger rhettinger

Labels
awaiting review
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kristjanvalur @rhettinger