Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-113755: Adapt the remaining functions in gcmodule.c to Argument Clinic #113756

Merged
merged 5 commits into from Jan 8, 2024
Merged

gh-113755: Adapt the remaining functions in gcmodule.c to Argument Clinic #113756

merged 5 commits into from Jan 8, 2024
+175 ∄1�728

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jan 5, 2024 •
edited by github-actions bot

  • Adapt gc.set_threshold to Argument Clinic
  • Adapt gc.get_referrers to Argument Clinic
  • Adapt gc.get_referents to Argument Clinic
  • Only update generations > 2 if needed

📚 Documentation preview 📚: https://cpython-previews--113756.org.readthedocs.build/

@bedevere-app bedevere-app bot mentioned this pull request Jan 5, 2024
Closed
@erlend-aasland erlend-aasland linked an issue Jan 5, 2024 that may be closed by this pull request
Adapt the remaining functions in gcmodule.c to Argument Clinic #113755
Closed
corona10
corona10 approved these changes Jan 6, 2024
View reviewed changes
Copy link
Member

@corona10 corona10 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@erlend-aasland
Copy link
Contributor Author

Thanks for the review, Donghee! I'll wait a day or two to give Pablo a chance to chime in, before landing; there is no rush to merge this :)

pablogsal
pablogsal approved these changes Jan 8, 2024
View reviewed changes
Copy link
Member

@pablogsal pablogsal left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Thanks a lot for doing this @erlend-aasland

@erlend-aasland erlend-aasland merged commit 35fa13d into python:main Jan 8, 2024
35 checks passed
@erlend-aasland erlend-aasland deleted the gc/clinic branch January 8, 2024 17:32
@erlend-aasland
Copy link
Contributor Author

Thanks for the reviews, Donghee and Pablo!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@corona10 corona10 corona10 approved these changes

@pablogsal pablogsal pablogsal approved these changes

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Adapt the remaining functions in gcmodule.c to Argument Clinic
3 participants
@erlend-aasland @corona10 @pablogsal