Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

GH-111485: Delete the old generator code. #113321

Merged
merged 5 commits into from Dec 21, 2023
Merged

GH-111485: Delete the old generator code. #113321

merged 5 commits into from Dec 21, 2023

Conversation

markshannon
Copy link
Member

@markshannon markshannon commented Dec 20, 2023 •
edited by bedevere-app bot

@bedevere-app bedevere-app bot mentioned this pull request Dec 20, 2023
Open
@Fidget-Spinner
Copy link
Member

Not a Makefile expert, but I think the new pycore_uop_metadata.h header needs to be added to the header list here as well https://github.com/python/cpython/blob/main/Makefile.pre.in#L1896 ? Not really sure.

@markshannon markshannon merged commit 723f4d6 into python:main Dec 21, 2023
36 checks passed
ryan-duve pushed a commit to ryan-duve/cpython that referenced this pull request Dec 26, 2023
@markshannon @ryan-duve
pythonGH-111485: Delete the old generator code. (pythonGH-113321)
cf884d8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gvanrossum gvanrossum gvanrossum approved these changes

@ericsnowcurrently ericsnowcurrently Awaiting requested review from ericsnowcurrently ericsnowcurrently is a code owner

Assignees
No one assigned
Labels
skip news
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@markshannon @Fidget-Spinner @gvanrossum