Skip to content

GH-113225: Speed up pathlib.Path.glob() #113226

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 6 commits into from
Jan 4, 2024
Merged

GH-113225: Speed up pathlib.Path.glob() #113226

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
6 commits
Select commit Hold shift + click to select a range
461b73d
GH-113225: Speed up `pathlib.Path.iterdir()` and `glob()`
barneygale Dec 17, 2023
38360dc
Maintain `_drv`, `_root`, `_tail_cached` values in children.
barneygale Dec 17, 2023
7a24a78
Revert "Maintain `_drv`, `_root`, `_tail_cached` values in children."
barneygale Dec 18, 2023
352ad99
Undo change to iterdir()
barneygale Dec 18, 2023
7072ac9
Merge branch 'main' into gh-113225
barneygale Dec 28, 2023
fbd4357
Maintain _str, _drv, _root and _tail_cached.
barneygale Jan 4, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 7 additions & 1 deletion Lib/pathlib/__init__.py
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -301,7 +301,13 @@ def _scandir(self):

def _make_child_entry(self, entry):
# Transform an entry yielded from _scandir() into a path object.
return self._make_child_relpath(entry.name)
path_str = entry.name if str(self) == '.' else entry.path
path = self.with_segments(path_str)
path._str = path_str
path._drv = self.drive
path._root = self.root
path._tail_cached = self._tail + [entry.name]
return path

def absolute(self):
"""Return an absolute version of this path
Expand Down
1 change: 1 addition & 0 deletions Misc/NEWS.d/next/Library/2023-12-17-04-43-57.gh-issue-113225.dhxhiZ.rst
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1 @@
Speed up :meth:`pathlib.Path.glob` by using :attr:`os.DirEntry.path` where possible.