Skip to content

gh-105375: Improve array.array exception handling #105594

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

erlend-aasland
Copy link
Contributor

@erlend-aasland erlend-aasland commented Jun 9, 2023

Fix a bug where 'tp_richcompare' could end up overwriting an exception.

Fix a bug where 'tp_richcompare' could end up overwriting an exception.
@erlend-aasland erlend-aasland merged commit 35cff54 into python:main Jun 11, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.11, 3.12.
🐍🍒⛏🤖 I'm not a witch! I'm not a witch!

@miss-islington
Copy link
Contributor

Sorry @erlend-aasland, I had trouble checking out the 3.12 backport branch.
Please retry by removing and re-adding the "needs backport to 3.12" label.
Alternatively, you can backport using cherry_picker on the command line.
cherry_picker 35cff545db7c7912046c0ce5627db2e4d2b60f57 3.12

@erlend-aasland erlend-aasland deleted the improve-array-error-handling branch June 11, 2023 09:58
miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
)

Fix a bug where 'tp_richcompare' could end up overwriting an exception.
(cherry picked from commit 35cff54)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105643 is a backport of this pull request to the 3.11 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.11 only security fixes label Jun 11, 2023
@erlend-aasland erlend-aasland added needs backport to 3.12 only security fixes and removed needs backport to 3.12 only security fixes labels Jun 11, 2023
@miss-islington
Copy link
Contributor

Thanks @erlend-aasland for the PR 🌮🎉.. I'm working now to backport this PR to: 3.12.
🐍🍒⛏🤖

miss-islington pushed a commit to miss-islington/cpython that referenced this pull request Jun 11, 2023
)

Fix a bug where 'tp_richcompare' could end up overwriting an exception.
(cherry picked from commit 35cff54)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
@bedevere-bot
Copy link

GH-105644 is a backport of this pull request to the 3.12 branch.

@bedevere-bot bedevere-bot removed the needs backport to 3.12 only security fixes label Jun 11, 2023
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
…105643)

Fix a bug where 'tp_richcompare' could end up overwriting an exception.
(cherry picked from commit 35cff54)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
erlend-aasland added a commit that referenced this pull request Jun 11, 2023
…105644)

Fix a bug where 'tp_richcompare' could end up overwriting an exception.
(cherry picked from commit 35cff54)

Co-authored-by: Erlend E. Aasland <erlend.aasland@protonmail.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants