New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-100972: For command line examples in the documentation, use "python" rather than "python3 #100973
base: main
Are you sure you want to change the base?
Conversation
furkanonder
commented
Jan 12, 2023
•
edited by bedevere-bot
edited by bedevere-bot
- Issue: For command line examples in the documentation, use "python" rather than "python3" #100972
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
@@ -73,7 +73,7 @@ something into it: | |||
|
|||
.. code-block:: shell-session | |||
|
|||
$ python3 -m venv example |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave python3
here as it is an instruction how to create a virtual environment. I didn't change it on purpose.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I agree since older systems may still have Python 2.7 set a python
.
@@ -259,7 +259,7 @@ one mentioned below are preferred. | |||
|
|||
See :mod:`venv` for an example of a package with a minimal ``__main__.py`` | |||
in the standard library. It doesn't contain a ``if __name__ == '__main__'`` | |||
block. You can invoke it with ``python3 -m venv [directory]``. | |||
block. You can invoke it with ``python -m venv [directory]``. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave python3
here as it is an instruction how to create a virtual environment. I didn't change it on purpose.
@@ -44,7 +44,7 @@ whichever version you want. | |||
To create a virtual environment, decide upon a directory where you want to | |||
place it, and run the :mod:`venv` module as a script with the directory path:: | |||
|
|||
python3 -m venv tutorial-env | |||
python -m venv tutorial-env |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I think we should leave python3
here as it is an instruction how to create a virtual environment. I didn't change it on purpose.
@@ -222,7 +222,7 @@ Other Language Changes | |||
(Contributed by Ngalim Siregar in :issue:`37444`.) | |||
|
|||
* Python now gets the absolute path of the script filename specified on | |||
the command line (ex: ``python3 script.py``): the ``__file__`` attribute of | |||
the command line (ex: ``python script.py``): the ``__file__`` attribute of |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see much value in changing old release notes.
Doesn't this assume that the system Python installation will be Python 3.x such that "python" will start a 3.x interpreter? If that's the case, it shouldn't be needed to specify "python3" for "-m venv" usages, right? Also, is it definitely the case that "python" will invoke 3.x on all platforms, old and new? For example I have some (not very) old Ubuntu machines where "python3" is needed. Anyone following along the documentation with this change could run into problems. |
On my Mac, |
If there are problems with the Mac, I think this PR should be reverted. |