Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-19083: IDNA prefix should be case insensitive #17726

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

bpo-19083: IDNA prefix should be case insensitive #17726

wants to merge 2 commits into from
+10 −3

Conversation

ZackerySpytz
Copy link
Contributor

@ZackerySpytz ZackerySpytz commented Dec 28, 2019 •
edited by miss-islington

Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-Authored-By: Pepijn de Vos pepijndevos@gmail.com

https://bugs.python.org/issue19083

Automerge-Triggered-By: @asvetlov

@ZackerySpytz @pepijndevos
bpo-19083: IDNA prefix should be case insensitive
8ba3632 
Any capitalization of "xn--" should be acceptable for the ACE prefix
(see https://tools.ietf.org/html/rfc3490#section-5).

Co-Authored-By: Pepijn de Vos <pepijndevos@gmail.com>
@ZackerySpytz
Copy link
Contributor Author

ZackerySpytz commented Dec 28, 2019

I plan on adding a news entry.

corona10
corona10 approved these changes Dec 29, 2019
View changes
Copy link
Member

@corona10 corona10 left a comment

Looks good to me :)

asvetlov
asvetlov reviewed Dec 29, 2019
View changes
Lib/encodings/idna.py Outdated Show resolved Hide resolved
@asvetlov asvetlov added 🤖 automerge PR will be merged once it's been approved and all CI passed needs backport to 3.7 needs backport to 3.8 and removed 🤖 automerge PR will be merged once it's been approved and all CI passed labels Jan 16, 2020
asvetlov
asvetlov requested changes Jan 16, 2020
View changes
Copy link
Contributor

@asvetlov asvetlov left a comment

The change looks good; please add NEWs entry.

@bedevere-bot
Copy link

bedevere-bot commented Jan 16, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

@pepijndevos
Copy link

pepijndevos commented May 23, 2021

Original patch author chiming in. Happy to see some activity here after close to a decade. Don't think I have the necessary rights to do the NEWS entry though, so I'll just be patient.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@asvetlov asvetlov

@corona10 corona10

Assignees
No one assigned
Labels
awaiting changes
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@ZackerySpytz @bedevere-bot @pepijndevos @asvetlov @corona10 @ambv @the-knights-who-say-ni @ezio-melotti