New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
gh-89532: Remove LibreSSL workarounds #28728
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for your PR.
Python 3.10 didn't actively drop support for LibreSSL. For a lack of better wording, we passively removed compatibility with forks that don't provide OpenSSL 1.1.1 API. I still like to keep some code so we can re-add LibreSSL support later.
Misc/NEWS.d/next/Core and Builtins/2021-10-05-05-00-16.bpo-45369.tluk_X.rst
Outdated
Show resolved
Hide resolved
A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated. Once you have made the requested changes, please leave a comment on this pull request containing the phrase |
bbd542d
to
351eaea
Compare
Co-authored-by: Christian Heimes <christian@python.org>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the quick fix!
I have made the requested changes; please review again |
Thanks for making the requested changes! @tiran: please review the changes made to this pull request. |
This PR is stale because it has been open for 30 days with no activity. |
Some time has passed, and I guess this patch sort of reflects the state of Python v3.10 with LibreSSL v3.5. Does that change anything for Python w.r.t. LibreSSL support? |
Of course I stumble upon this just after posting. |
It is unlikely that we will officially support LibreSSL. Even if LibreSSL would become feature compatible with OpenSSL, we just don't have to resources to test and verify that Python works correctly with LibreSSL. Is LibreSSL still relevant? AFAIK only OpenBSD uses it. All Linux distros have dropped support for LibreSSL, even Gentoo. FreeBSD uses OpenSSL and NetBSD seems to prefer OpenSSL as well (they have OpenSSL 1.1.1n and LibreSSL 2.7.4 from 2018). |
OpenBSD and to some extend OpenWrt. The patch I linked to is that user maintained Gentoo LibreSSL overlay, which was mentioned in that news item you linked to. Seems used but nothing official. The usage in OpenWrt in somewhat special. A host python is compiled with LibreSSL, which is then used to cross compile the target python and target python packages, but that's all using OpenSSL then. So the host python with LibreSSL isn't something critical that gets shipped. And that got us to the question of how painful it is to maintain the python+libressl patch or if OpenWrt should switch the host part to OpenSSL. |
For the record: Python 3.10.7 builds with LibreSSL 3.7.0 without any further patches. |
If no deliberate removal of LibreSSL calls is planned, should we keep this PR and its parent issue open? |
It is still possible to use it on Gentoo with the overlay. https://github.com/gentoo/libressl |
Python 3.10 drops support for LibreSSL (as per PEP 644), but there are still a few workarounds & mentions of LibreSSL in the source code.
The related PR cleans the code of any LibreSSL workarounds or mentions.
https://bugs.python.org/issue45369