Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

gh-113569: Display calls in Mock.assert_has_calls failure when empty #113573

Merged
merged 5 commits into from Jan 4, 2024
Merged

gh-113569: Display calls in Mock.assert_has_calls failure when empty #113573

merged 5 commits into from Jan 4, 2024

Conversation

wookie184
Copy link
Contributor

@wookie184 wookie184 commented Dec 29, 2023 •
edited by bedevere-app bot

@bedevere-app bedevere-app bot mentioned this pull request Dec 29, 2023
Closed
@wookie184
Copy link
Contributor Author

News failed the lint, but now i'm thinking this probably doesn't even need news, should I just remove it?

sobolevn
sobolevn reviewed Dec 30, 2023
View reviewed changes
Copy link
Member

@sobolevn sobolevn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This change needs a NEWS entry :)

Lib/test/test_unittest/testmock/testmock.py Outdated Show resolved Hide resolved
Lib/unittest/mock.py Outdated Show resolved Hide resolved
cjw296
cjw296 reviewed Dec 30, 2023
View reviewed changes
Lib/unittest/mock.py Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka reviewed Dec 30, 2023
View reviewed changes
Lib/unittest/mock.py Outdated Show resolved Hide resolved
Lib/test/test_unittest/testmock/testmock.py Show resolved Hide resolved
Lib/unittest/mock.py Outdated Show resolved Hide resolved
serhiy-storchaka
serhiy-storchaka reviewed Dec 30, 2023
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you think about displaying " Actual: not called" like in assert_called_with()?

@wookie184
Copy link
Contributor Author

Thank you everyone for the reviews so far by the way, it's appreciated :)

@cjw296
Copy link
Contributor

cjw296 commented Jan 4, 2024

@wookie184 - this looks ready to merge now, is that correct?

serhiy-storchaka
serhiy-storchaka approved these changes Jan 4, 2024
View reviewed changes
Copy link
Member

@serhiy-storchaka serhiy-storchaka left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@serhiy-storchaka serhiy-storchaka merged commit 1600d78 into python:main Jan 4, 2024
29 checks passed
@serhiy-storchaka
Copy link
Member

Thank you for your contribution @wookie184. It is not only added a useful feature, but made the code tidier in general.

@cjw296
Copy link
Contributor

cjw296 commented Jan 4, 2024

Any backports needed @serhiy-storchaka ?

@serhiy-storchaka
Copy link
Member

This is a new feature, not a bug fix.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@sobolevn sobolevn sobolevn left review comments

@cjw296 cjw296 cjw296 approved these changes

@serhiy-storchaka serhiy-storchaka serhiy-storchaka approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Display actual calls for unittest.assert_has_calls even if empty
4 participants
@wookie184 @cjw296 @serhiy-storchaka @sobolevn