python / cpython

Sponsor

Sponsor python/cpython
Watch 1.4k
Star 36.3k
Fork 17.8k

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

bpo-40383: Reprs of subclasses of weakref now contain actual type name #19707

Open

OhBonsai wants to merge 1 commit into python:master from OhBonsai:bpo-40383

+28 −10

OhBonsai commented Apr 25, 2020 •

edited by bedevere-bot

Reprs of subclasses of weakref now contain actual type name

https://bugs.python.org/issue40383

the-knights-who-say-ni added the CLA signed label

bedevere-bot added the awaiting review label

corona10 requested changes

Objects/weakrefobject.c Outdated Show resolved Hide resolved

bedevere-bot removed the awaiting review label

bedevere-bot commented Apr 25, 2020

A Python core developer has requested some changes be made to your pull request before we can consider merging it. If you could please address their requests along with any other requests in other reviews from core developers that would be appreciated.

Once you have made the requested changes, please leave a comment on this pull request containing the phrase I have made the requested changes; please review again. I will then notify any core developers who have left a review that you're ready for them to take another look at this pull request.

bedevere-bot added the awaiting changes label

corona10 requested changes

Member

corona10 left a comment

Thanks for the contribution, you might add NEWS.d for this PR.
https://devguide.python.org/committing/#what-s-new-and-news-entries

And @serhiy-storchaka will decide that this PR would be accepted.

corona10 requested a review from serhiy-storchaka

Author

OhBonsai commented Apr 25, 2020

I have made the requested changes; please review again

@serhiy-storchaka

bedevere-bot added awaiting change review and removed awaiting changes labels

bedevere-bot commented Apr 25, 2020

Thanks for making the requested changes!

@corona10: please review the changes made to this pull request.

bedevere-bot requested a review from corona10

Author

OhBonsai commented Apr 25, 2020

Thank you for reminding me. I See

OhBonsai closed this

OhBonsai reopened this

corona10 approved these changes

Member

corona10 left a comment

I am okay with the change, but let's wait @serhiy-storchaka 's review!

bedevere-bot added awaiting merge and removed awaiting change review labels

Author

OhBonsai commented Apr 29, 2020 •

edited

I am okay with the change, but let's wait @serhiy-storchaka 's review!

Haha, This's my first time contributing to c project... Almost first time contributing to open source project, Thank you for you replay and review

csabella requested review from serhiy-storchaka and removed request for serhiy-storchaka

Author

OhBonsai commented Jun 12, 2020

@serhiy-storchaka TBR plz 😄

OhBonsai force-pushed the OhBonsai:bpo-40383 branch from 37f2230 to 719d410


          fix: Reprs of subclasses of weakref now contain actual type name

967c8f5

OhBonsai force-pushed the OhBonsai:bpo-40383 branch from 719d410 to 967c8f5

Author

OhBonsai commented Jul 16, 2020

@serhiy-storchaka Please take a look in your free time, thanks~

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment